fix(core): Handle both variations of multipart/mixed preamble#3172
Merged
fix(core): Handle both variations of multipart/mixed preamble#3172
Conversation
JoviDeCroock
approved these changes
Apr 20, 2023
Merged
Contributor
|
You could just pull in meros and get this kind of stuff for free |
Member
Author
|
@maraisr We can't really any longer 😄 At least looking at it from what we did in the last major, the implementation now also throws out some smaller things we don't need and is combined with event streams, so I'm fine with fixing a regression from the refactor at the benefit of the combined implementation 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This implements a fix for a regression in #3155.
Basically, we now split the incoming
multipart/mixedresponse byCRLFand the boundary. However, our tests send the preamble split byCRLF+ boundary, while some newer variations would only send the boundary as the preamble and only after useCRLFThis caused the first payload to be malformed and disregarded.
Set of changes
CRLFsplitting