Load system CA certificates by default on empty HTTPSConnection#1608
Merged
sethmlarson merged 7 commits intourllib3:masterfrom May 23, 2019
Merged
Load system CA certificates by default on empty HTTPSConnection#1608sethmlarson merged 7 commits intourllib3:masterfrom
sethmlarson merged 7 commits intourllib3:masterfrom
Conversation
theacodes
approved these changes
May 16, 2019
sethmlarson
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
- Coverage 99.73% 99.47% -0.27%
==========================================
Files 22 22
Lines 1892 1901 +9
==========================================
+ Hits 1887 1891 +4
- Misses 5 10 +5
Continue to review full report at Codecov.
|
sethmlarson
force-pushed
the
load-defaults
branch
from
7639407 to
bd33f3e
Compare
Member
|
It's a nice change, but unfortunately, this pull request decreases coverage |
Member
|
:'-( |
Member
Author
|
Right, only wrote tests for the Connection level logic. Dang, I'm on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1603.