Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: replace repetitive scan loops with 'findSetFlag'
  • Loading branch information
BrandonIrizarry committed Aug 15, 2026
commit 81479e019b13dc4e0169290cb141edc0c1b1c45f
57 changes: 29 additions & 28 deletions flag_mutex.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,44 +19,45 @@ type MutuallyExclusiveFlags struct {
func (grp MutuallyExclusiveFlags) check(_ *Command) error {
e := &mutuallyExclusiveGroup{}

// First, find the index of the group were the flag was set
// (if it exists.)
var i int
var oneSet bool
// Check for the use of a mutually-exclusive flag, starting at
// the first group.
name, i, ok := grp.findSetFlag(0)
if ok {
e.flag1Name = name
i++

flagGroupLoop:
for ; i < len(grp.Flags); i++ {
group := grp.Flags[i]

// For each flag inside this group, check if it's set.
for _, flg := range group {
if flg.IsSet() {
e.flag1Name = flg.Names()[0]
oneSet = true
break flagGroupLoop
}
// Check for the use of a flag in a mutually exclusive
// relationship with the one we just found.
if name2, _, ok := grp.findSetFlag(i); ok {
e.flag2Name = name2
return e
}
}

// Next, continue from the flag group just after the one we
// stopped at above, to see if another flag is set. If so,
// return an error.
i++
for ; i < len(grp.Flags); i++ {
group := grp.Flags[i]
if !ok && grp.Required {
return &mutuallyExclusiveGroupRequiredFlag{flags: &grp}
}

return nil
}

// findSetFlag is used in [MutuallyExclusiveFlags.check] to find
// whether at least one flag inside a mutually exclusive flag group is
// set. If so, return the flag name, position at which it's set, and
// Boolean true (indicating that a flag was found.) Else, return all
// zero values.
func (grp MutuallyExclusiveFlags) findSetFlag(startIdx int) (string, int, bool) {
for i := startIdx; i < len(grp.Flags); i++ {
flags := grp.Flags[i]

for _, flg := range group {
for _, flg := range flags {
if flg.IsSet() {
e.flag2Name = flg.Names()[0]
return e
return flg.Names()[0], i, true
}
}
}

if !oneSet && grp.Required {
return &mutuallyExclusiveGroupRequiredFlag{flags: &grp}
}
return nil
return "", 0, false
}

func (grp MutuallyExclusiveFlags) propagateCategory() {
Expand Down