flag: replace regexp use by kolyshkin · Pull Request #2288 · urfave/cli

kolyshkin · 2026-03-20T18:37:45Z

What type of PR is this?

cleanup

What this PR does / why we need it:

Commit ec05a8d introduces the only (non-test) user of regexp package.
It is pretty easy to not use regexp here, so let's get rid of it.

References:

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Testing

Assuming existing tests cover the change.

Release Notes

Remove regexp dependency.

kolyshkin · 2026-03-20T22:56:48Z

@dearchap PTAL

dearchap · 2026-03-21T01:41:15Z

@kolyshkin can you resolve the conflicts ?

Commit ec05a8d introduces the only (non-test) user of regexp package. It is pretty easy to not use regexp here, so let's get rid of it. Signed-off-by: Kir Kolyshkin <[email protected]>

abitrolly · 2026-03-21T09:29:33Z

 		// v1 -> v2 migration warning zone:
		// Strip off anything after the first found comma or space, which
		// *hopefully* makes it a tiny bit more obvious that unexpected behavior is
		// caused by using the v1 form of stringly typed "Name".

What all this comment is about? Is it still actual for v3?

dearchap · 2026-03-21T13:59:55Z

@abitrolly yes. Still valid.

abitrolly · 2026-03-22T06:54:20Z

@kolyshkin how did you trace size changes? Perhaps we could use a CI/CD bot to evaluate PRs.

kolyshkin · 2026-03-22T18:25:06Z

@kolyshkin how did you trace size changes?

See opencontainers/runc#5184 (comment) (about 500K)

This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [github.com/urfave/cli/v3](https://github.com/urfave/cli) | require | minor | `v3.7.0` → `v3.8.0` | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/urfave/cli/badge)](https://securityscorecards.dev/viewer/?uri=github.com/urfave/cli) | --- > ⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/23) for more information. --- ### Release Notes <details> <summary>urfave/cli (github.com/urfave/cli/v3)</summary> ### [`v3.8.0`](https://github.com/urfave/cli/releases/tag/v3.8.0) [Compare Source](urfave/cli@v3.7.0...v3.8.0) #### What's Changed - chore(deps): bump mkdocs-material from 9.7.1 to 9.7.2 in the python-packages group by [@dependabot](https://github.com/dependabot)\[bot] in [#2267](urfave/cli#2267) - chore(deps): bump mkdocs-material from 9.7.2 to 9.7.3 in the python-packages group by [@dependabot](https://github.com/dependabot)\[bot] in [#2272](urfave/cli#2272) - chore(deps): bump mkdocs-material from 9.7.3 to 9.7.4 in the python-packages group by [@dependabot](https://github.com/dependabot)\[bot] in [#2276](urfave/cli#2276) - Fix: check MutuallyExclusiveFlags across parent command chain by [@siutsin](https://github.com/siutsin) in [#2274](urfave/cli#2274) - Modernize source code by [@kolyshkin](https://github.com/kolyshkin) in [#2289](urfave/cli#2289) - flag: replace regexp use by [@kolyshkin](https://github.com/kolyshkin) in [#2288](urfave/cli#2288) - chore(deps): bump mkdocs-material from 9.7.4 to 9.7.5 in the python-packages group by [@dependabot](https://github.com/dependabot)\[bot] in [#2284](urfave/cli#2284) - Fix:(issue\_2281) Remove incorrect check for local flag for set by [@dearchap](https://github.com/dearchap) in [#2290](urfave/cli#2290) - Fix:(issue\_2275) Make flag action execution consistent by [@dearchap](https://github.com/dearchap) in [#2295](urfave/cli#2295) - Fix:(issue\_2293) --flag="" no longer rejected as missing argument by [@idelchi](https://github.com/idelchi) in [#2297](urfave/cli#2297) - Fix:(issue\_2292) Empty positional args no longer break parse loop by [@idelchi](https://github.com/idelchi) in [#2296](urfave/cli#2296) #### New Contributors - [@idelchi](https://github.com/idelchi) made their first contribution in [#2297](urfave/cli#2297) **Full Changelog**: <urfave/cli@v3.7.0...v3.8.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday ( * 0-4,22-23 * * 1-5 ), Only on Sunday and Saturday ( * * * * 0,6 ) (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://altlinux.space/stapler/stplr/pulls/376 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

kolyshkin requested a review from a team as a code owner March 20, 2026 18:37

kolyshkin mentioned this pull request Mar 20, 2026

chore(deps): upgrade urfave/cli from v1 to v3 opencontainers/runc#5184

Merged

flag: replace regexp use

cb07aa4

Commit ec05a8d introduces the only (non-test) user of regexp package. It is pretty easy to not use regexp here, so let's get rid of it. Signed-off-by: Kir Kolyshkin <[email protected]>

kolyshkin force-pushed the no-regexp branch from 66ae1eb to cb07aa4 Compare March 21, 2026 01:45

dearchap merged commit 58e99ee into urfave:main Mar 21, 2026
9 checks passed

dearchap approved these changes Mar 21, 2026

View reviewed changes

kolyshkin deleted the no-regexp branch March 22, 2026 18:25

kolyshkin mentioned this pull request Oct 5, 2026

Significant binary size increase between rc10 -> rc92 opencontainers/runc#2589

Open

Navigation Menu

Repository navigation

flag: replace regexp use - #2288

flag: replace regexp use#2288
dearchap merged 1 commit into
urfave:mainfrom
kolyshkin:no-regexp

kolyshkin commented Mar 20, 2026

Uh oh!

kolyshkin commented Mar 20, 2026

Uh oh!

dearchap commented Mar 21, 2026

Uh oh!

abitrolly commented Mar 21, 2026

Uh oh!

dearchap commented Mar 21, 2026

Uh oh!

Uh oh!

abitrolly commented Mar 22, 2026

Uh oh!

kolyshkin commented Mar 22, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kolyshkin commented Mar 20, 2026

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Testing

Release Notes

Uh oh!

kolyshkin commented Mar 20, 2026

Uh oh!

dearchap commented Mar 21, 2026

Uh oh!

abitrolly commented Mar 21, 2026

Uh oh!

dearchap commented Mar 21, 2026

Uh oh!

Uh oh!

abitrolly commented Mar 22, 2026

Uh oh!

kolyshkin commented Mar 22, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants