Repository navigation
Fix:(issue_2244) Dont check req flags for help and completion commands - #2245
Merged
Merged
Conversation
louisroyer
approved these changes
Jan 11, 2026
louisroyer
left a comment
louisroyer
left a comment
There was a problem hiding this comment.
I tested this PR, and this works as intended. Thank you 👍
yassinebenaid
approved these changes
Jan 12, 2026
radermacher-iits
pushed a commit
to kubara-io/kubara
that referenced
this pull request
Feb 19, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/urfave/cli/v3](https://github.com/urfave/cli) | require | patch | `v3.6.1` → `v3.6.2` | --- ### Release Notes <details> <summary>urfave/cli (github.com/urfave/cli/v3)</summary> ### [`v3.6.2`](https://github.com/urfave/cli/releases/tag/v3.6.2) [Compare Source](urfave/cli@v3.6.1...v3.6.2) #### What's Changed - chore(deps): bump actions/checkout from 5 to 6 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2230](urfave/cli#2230) - chore(deps): bump mkdocs-material from 9.6.23 to 9.7.0 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2231](urfave/cli#2231) - Improve test coverage by [@​dearchap](https://github.com/dearchap) in [#​2236](urfave/cli#2236) - Add more tests to improve code coverage by [@​dearchap](https://github.com/dearchap) in [#​2237](urfave/cli#2237) - Fix:(issue\_2238) Dont process flags for completion command by [@​dearchap](https://github.com/dearchap) in [#​2239](urfave/cli#2239) - Fix:(issue\_2228) Fix for default command by [@​dearchap](https://github.com/dearchap) in [#​2232](urfave/cli#2232) - chore(deps): bump mkdocs-material from 9.7.0 to 9.7.1 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2242](urfave/cli#2242) - Docs: correct typo in migration guide by [@​kzygmans](https://github.com/kzygmans) in [#​2243](urfave/cli#2243) - Fix:(issue\_2244) Dont check req flags for help and completion commands by [@​dearchap](https://github.com/dearchap) in [#​2245](urfave/cli#2245) - Only show separator if command has usage text by [@​mikecluck](https://github.com/mikecluck) in [#​2247](urfave/cli#2247) #### New Contributors - [@​kzygmans](https://github.com/kzygmans) made their first contribution in [#​2243](urfave/cli#2243) - [@​mikecluck](https://github.com/mikecluck) made their first contribution in [#​2247](urfave/cli#2247) **Full Changelog**: <urfave/cli@v3.6.1...v3.6.2> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi44NC4yIiwidXBkYXRlZEluVmVyIjoiNDIuODQuMiIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119--> Reviewed-on: https://kubara.git.onstackit.cloud/STACKIT/kubara/pulls/243
|
Regression: #2271 |
barry3406
added a commit
to barry3406/cli-1
that referenced
this pull request
Apr 19, 2026
PR urfave#2245 introduced a regression by short-circuiting pre-parse for any command named "help", which silently dropped flags and arguments on user-supplied help commands. Keep the pre-parse path intact and instead skip the required-flag enforcement for the help and completion commands, which was the actual goal of urfave#2245. Fixes urfave#2271
pat-s
pushed a commit
to pat-s/backporter
that referenced
this pull request
Nov 11, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [github.com/urfave/cli/v3](https://github.com/urfave/cli) | `v3.6.1` → `v3.9.0` |  |  | --- ### Release Notes <details> <summary>urfave/cli (github.com/urfave/cli/v3)</summary> ### [`v3.9.0`](https://github.com/urfave/cli/releases/tag/v3.9.0) [Compare Source](urfave/cli@v3.8.0...v3.9.0) #### What's Changed - chore(deps): bump codecov/codecov-action from 5 to 6 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2300](urfave/cli#2300) - chore(deps): bump the python-packages group across 1 directory with 3 updates by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2301](urfave/cli#2301) - docs: fix typo by [@​acrobatstick](https://github.com/acrobatstick) in [#​2299](urfave/cli#2299) - feat: add descriptions for bash and powershell autocompletion by [@​gabelluardo](https://github.com/gabelluardo) in [#​2298](urfave/cli#2298) - Made command help more consistent by [@​markshep-wbg](https://github.com/markshep-wbg) in [#​2287](urfave/cli#2287) - Fix:(issue\_2285): correct function and variable naming in fish completion script by [@​TimSoethout](https://github.com/TimSoethout) in [#​2286](urfave/cli#2286) - fix(ci): update docs after bash completion update by [@​gabelluardo](https://github.com/gabelluardo) in [#​2307](urfave/cli#2307) - fix: apply SliceFlagSeparator to env var sources by [@​lawrence3699](https://github.com/lawrence3699) in [#​2309](urfave/cli#2309) - fix: don't print empty line to stderr when Exit message is empty by [@​Yanhu007](https://github.com/Yanhu007) in [#​2310](urfave/cli#2310) - flag: prevent BoolWithInverseFlag.String from panicking without a tab by [@​alliasgher](https://github.com/alliasgher) in [#​2311](urfave/cli#2311) - refactor: bash completion script by [@​gabelluardo](https://github.com/gabelluardo) in [#​2308](urfave/cli#2308) - fix: drop shebang from bash completion template by [@​barry3406](https://github.com/barry3406) in [#​2317](urfave/cli#2317) - fix: show flag completions when completing a double-dash prefix by [@​morozov](https://github.com/morozov) in [#​2316](urfave/cli#2316) - fix: parse flags for help subcommand ([#​2271](urfave/cli#2271)) by [@​barry3406](https://github.com/barry3406) in [#​2319](urfave/cli#2319) - fix: show BoolWithInverseFlag aliases in help text by [@​wucm667](https://github.com/wucm667) in [#​2321](urfave/cli#2321) #### New Contributors - [@​gabelluardo](https://github.com/gabelluardo) made their first contribution in [#​2298](urfave/cli#2298) - [@​markshep-wbg](https://github.com/markshep-wbg) made their first contribution in [#​2287](urfave/cli#2287) - [@​lawrence3699](https://github.com/lawrence3699) made their first contribution in [#​2309](urfave/cli#2309) - [@​Yanhu007](https://github.com/Yanhu007) made their first contribution in [#​2310](urfave/cli#2310) - [@​alliasgher](https://github.com/alliasgher) made their first contribution in [#​2311](urfave/cli#2311) - [@​barry3406](https://github.com/barry3406) made their first contribution in [#​2317](urfave/cli#2317) - [@​morozov](https://github.com/morozov) made their first contribution in [#​2316](urfave/cli#2316) - [@​wucm667](https://github.com/wucm667) made their first contribution in [#​2321](urfave/cli#2321) **Full Changelog**: <urfave/cli@v3.8.0...v3.9.0> ### [`v3.8.0`](https://github.com/urfave/cli/releases/tag/v3.8.0) [Compare Source](urfave/cli@v3.7.0...v3.8.0) #### What's Changed - chore(deps): bump mkdocs-material from 9.7.1 to 9.7.2 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2267](urfave/cli#2267) - chore(deps): bump mkdocs-material from 9.7.2 to 9.7.3 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2272](urfave/cli#2272) - chore(deps): bump mkdocs-material from 9.7.3 to 9.7.4 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2276](urfave/cli#2276) - Fix: check MutuallyExclusiveFlags across parent command chain by [@​siutsin](https://github.com/siutsin) in [#​2274](urfave/cli#2274) - Modernize source code by [@​kolyshkin](https://github.com/kolyshkin) in [#​2289](urfave/cli#2289) - flag: replace regexp use by [@​kolyshkin](https://github.com/kolyshkin) in [#​2288](urfave/cli#2288) - chore(deps): bump mkdocs-material from 9.7.4 to 9.7.5 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2284](urfave/cli#2284) - Fix:(issue\_2281) Remove incorrect check for local flag for set by [@​dearchap](https://github.com/dearchap) in [#​2290](urfave/cli#2290) - Fix:(issue\_2275) Make flag action execution consistent by [@​dearchap](https://github.com/dearchap) in [#​2295](urfave/cli#2295) - Fix:(issue\_2293) --flag="" no longer rejected as missing argument by [@​idelchi](https://github.com/idelchi) in [#​2297](urfave/cli#2297) - Fix:(issue\_2292) Empty positional args no longer break parse loop by [@​idelchi](https://github.com/idelchi) in [#​2296](urfave/cli#2296) #### New Contributors - [@​idelchi](https://github.com/idelchi) made their first contribution in [#​2297](urfave/cli#2297) **Full Changelog**: <urfave/cli@v3.7.0...v3.8.0> ### [`v3.7.0`](https://github.com/urfave/cli/releases/tag/v3.7.0) [Compare Source](urfave/cli@v3.6.2...v3.7.0) #### What's Changed - Fix: use the correct type name in the tracef message by [@​icholy](https://github.com/icholy) in [#​2251](urfave/cli#2251) - chore(deps): bump mkdocs-git-revision-date-localized-plugin from 1.5.0 to 1.5.1 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2252](urfave/cli#2252) - Fix:(issue\_2254) Fix incorrect handling of arg after short option token by [@​dearchap](https://github.com/dearchap) in [#​2255](urfave/cli#2255) - feat: ShellComplete for fish by [@​marcusramberg](https://github.com/marcusramberg) in [#​2256](urfave/cli#2256) - Fix: propagate MutuallyExclusiveFlags persistent flags to subcommands by [@​siutsin](https://github.com/siutsin) in [#​2266](urfave/cli#2266) - feat: support dynamic fish completion by [@​Maks1mS](https://github.com/Maks1mS) in [#​2270](urfave/cli#2270) - fix(help): show GLOBAL OPTIONS for leaf subcommands when HideHelpCommand is true by [@​TimSoethout](https://github.com/TimSoethout) in [#​2269](urfave/cli#2269) #### New Contributors - [@​marcusramberg](https://github.com/marcusramberg) made their first contribution in [#​2256](urfave/cli#2256) - [@​siutsin](https://github.com/siutsin) made their first contribution in [#​2266](urfave/cli#2266) - [@​TimSoethout](https://github.com/TimSoethout) made their first contribution in [#​2269](urfave/cli#2269) **Full Changelog**: <urfave/cli@v3.6.2...v3.7.0> ### [`v3.6.2`](https://github.com/urfave/cli/releases/tag/v3.6.2) [Compare Source](urfave/cli@v3.6.1...v3.6.2) #### What's Changed - chore(deps): bump actions/checkout from 5 to 6 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2230](urfave/cli#2230) - chore(deps): bump mkdocs-material from 9.6.23 to 9.7.0 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2231](urfave/cli#2231) - Improve test coverage by [@​dearchap](https://github.com/dearchap) in [#​2236](urfave/cli#2236) - Add more tests to improve code coverage by [@​dearchap](https://github.com/dearchap) in [#​2237](urfave/cli#2237) - Fix:(issue\_2238) Dont process flags for completion command by [@​dearchap](https://github.com/dearchap) in [#​2239](urfave/cli#2239) - Fix:(issue\_2228) Fix for default command by [@​dearchap](https://github.com/dearchap) in [#​2232](urfave/cli#2232) - chore(deps): bump mkdocs-material from 9.7.0 to 9.7.1 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2242](urfave/cli#2242) - Docs: correct typo in migration guide by [@​kzygmans](https://github.com/kzygmans) in [#​2243](urfave/cli#2243) - Fix:(issue\_2244) Dont check req flags for help and completion commands by [@​dearchap](https://github.com/dearchap) in [#​2245](urfave/cli#2245) - Only show separator if command has usage text by [@​mikecluck](https://github.com/mikecluck) in [#​2247](urfave/cli#2247) #### New Contributors - [@​kzygmans](https://github.com/kzygmans) made their first contribution in [#​2243](urfave/cli#2243) - [@​mikecluck](https://github.com/mikecluck) made their first contribution in [#​2247](urfave/cli#2247) **Full Changelog**: <urfave/cli@v3.6.1...v3.6.2> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi43OC4yIiwidXBkYXRlZEluVmVyIjoiNDMuMzEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://codefloe.com/pat-s/backporter/pulls/13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #2244
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
make test
Release Notes
(REQUIRED)