Add more tests to improve code coverage by dearchap · Pull Request #2237 · urfave/cli

dearchap · 2025-11-30T17:01:24Z

What type of PR is this?

(REQUIRED)

cleanup

What this PR does / why we need it:

(REQUIRED)

Improve test coverage to beyond 99%

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

make test

Release Notes

(REQUIRED)

Added more tests to improve coverage

mustafabayar · 2026-02-03T14:19:53Z

 	}

 	if exitErr, ok := err.(ExitCoder); ok {
-		if err.Error() != "" {


@dearchap was this code change intentional? Calling Exit with an empty message now adds an unnecessary empty line to stderr:

cli.Exit("", exitError.ExitCode())

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/urfave/cli/v3](https://github.com/urfave/cli) | require | patch | `v3.6.1` → `v3.6.2` | --- ### Release Notes <details> <summary>urfave/cli (github.com/urfave/cli/v3)</summary> ### [`v3.6.2`](https://github.com/urfave/cli/releases/tag/v3.6.2) [Compare Source](urfave/cli@v3.6.1...v3.6.2) #### What's Changed - chore(deps): bump actions/checkout from 5 to 6 by [@dependabot](https://github.com/dependabot)\[bot] in [#2230](urfave/cli#2230) - chore(deps): bump mkdocs-material from 9.6.23 to 9.7.0 in the python-packages group by [@dependabot](https://github.com/dependabot)\[bot] in [#2231](urfave/cli#2231) - Improve test coverage by [@dearchap](https://github.com/dearchap) in [#2236](urfave/cli#2236) - Add more tests to improve code coverage by [@dearchap](https://github.com/dearchap) in [#2237](urfave/cli#2237) - Fix:(issue\_2238) Dont process flags for completion command by [@dearchap](https://github.com/dearchap) in [#2239](urfave/cli#2239) - Fix:(issue\_2228) Fix for default command by [@dearchap](https://github.com/dearchap) in [#2232](urfave/cli#2232) - chore(deps): bump mkdocs-material from 9.7.0 to 9.7.1 in the python-packages group by [@dependabot](https://github.com/dependabot)\[bot] in [#2242](urfave/cli#2242) - Docs: correct typo in migration guide by [@kzygmans](https://github.com/kzygmans) in [#2243](urfave/cli#2243) - Fix:(issue\_2244) Dont check req flags for help and completion commands by [@dearchap](https://github.com/dearchap) in [#2245](urfave/cli#2245) - Only show separator if command has usage text by [@mikecluck](https://github.com/mikecluck) in [#2247](urfave/cli#2247) #### New Contributors - [@kzygmans](https://github.com/kzygmans) made their first contribution in [#2243](urfave/cli#2243) - [@mikecluck](https://github.com/mikecluck) made their first contribution in [#2247](urfave/cli#2247) **Full Changelog**: <urfave/cli@v3.6.1...v3.6.2> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://kubara.git.onstackit.cloud/STACKIT/kubara/pulls/243

Add more tests to improve code coverage

91ed11d

dearchap requested a review from a team as a code owner November 30, 2025 17:01

Juneezee approved these changes Nov 30, 2025

View reviewed changes

dearchap merged commit 1f225b1 into urfave:main Nov 30, 2025
8 of 9 checks passed

mustafabayar reviewed Feb 3, 2026

View reviewed changes

mustafabayar mentioned this pull request Feb 11, 2026

v3.6.2 adds empty line to stderr when cli.Exit is called with empty message #2263

Closed

2 of 3 tasks

Yanhu007 mentioned this pull request Apr 12, 2026

fix: don't print empty line to stderr when Exit message is empty #2310

Merged

Navigation Menu

Repository navigation

Add more tests to improve code coverage - #2237

Add more tests to improve code coverage#2237
dearchap merged 1 commit into
urfave:mainfrom
dearchap:improve_test_cov_11292025

dearchap commented Nov 30, 2025

Uh oh!

Uh oh!

mustafabayar Feb 3, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dearchap commented Nov 30, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Testing

Release Notes

Uh oh!

Uh oh!

mustafabayar Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants