Skip to content

Conversation

@6543
Copy link
Contributor

@6543 6543 commented Jul 5, 2024

similar to EnvVar()

It's just a smal helper to make NewValueSourceChain more usefull :)

similar to EnvVar()
@6543 6543 requested a review from a team as a code owner July 5, 2024 23:19
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Jul 6, 2024
@6543 6543 force-pushed the File_ValueSource branch from edea41e to bb1b3a9 Compare July 6, 2024 01:26
@6543
Copy link
Contributor Author

6543 commented Jul 6, 2024

will be used in woodpecker-ci/woodpecker#2951 ...

@abitrolly abitrolly mentioned this pull request Jul 6, 2024
18 tasks
Copy link
Member

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I'm holding off for more maintainers to speak up :)

Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and LGTM

@abennett abennett merged commit 6d6416e into urfave:main Jul 7, 2024
@6543 6543 deleted the File_ValueSource branch July 8, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants