Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: urfave/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.22.7
Choose a base ref
...
head repository: urfave/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.22.8
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Apr 27, 2022

  1. ci: add go 1.17.x and 1.18.x, fix failing test 

    One test is failing with Go 1.17+ since it now panics instead of
returning an error. Catch the panic and consider the test passed.

With that out of the door, add Go 1.17.x and 1.18.x to the testing
matrix.

While at it, do not use && in run since it is executed by a shell with
set -e, thus making && redundant.

Signed-off-by: Kir Kolyshkin <[email protected]>
    @kolyshkin
    kolyshkin committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    6564c0f View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Merge pull request #1379 from kolyshkin/v1-fix-ci 

    [v1] fix CI, add Go 1.17.x and 1.18.x
    @meatballhat
    meatballhat authored Apr 28, 2022
    Configuration menu
    Copy the full SHA
    936bd2e View commit details
    Browse the repository at this point in the history
Loading