Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: urfave/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.22.5
Choose a base ref
...
head repository: urfave/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.22.6
Choose a head ref
  • 2 commits
  • 5 files changed
  • 4 contributors

Commits on Apr 21, 2022

  1. Ci config trimming (#1355) 

    * add ProgramName and CommandName variables

* add comments to variables

* add test case

* refer program name instead of app name

* Update command_test.go

add err to the log

* fix failing tests

* Cut out many CI things

that either don't work on v1 anymore or are specific to the `master`
branch.

* More general v1 branch CI updates :-/

* More ~fighting~ playing with CI bits

* Drop back to only testing go 1.16.x

as 1.15.x is no longer supported by the Go team and both 1.17.x and
1.18.x can't run the tests

* Back out some changes from #973

Co-authored-by: Ajitem Sahasrabuddhe <[email protected]>
    @meatballhat @asahasrabuddhe
    meatballhat and asahasrabuddhe authored Apr 21, 2022
    Configuration menu
    Copy the full SHA
    8d987df View commit details
    Browse the repository at this point in the history

  2. Merging 1135 fix flag parsing (#1356) 

    * Fix regression in handling flag-values starting with hyphen

Fix for a regression between v1.22.1 and v1.22.2, where
flag values starting with a hyphen would be parsed as a flag:

    runc update test_update --memory-swap -1
    Incorrect Usage: flag provided but not defined: -1

This problem was caused by `reorderArgs()` not properly checking
if the next arg in the list was a value for the flag (and not
the next flag);

Before this patch:

    args before reordering: --opt,--opt-value,arg1
    args after reordering:  --opt,arg1,--opt-value
    args before reordering: --opt,--opt-value,arg1,arg2
    args after reordering:  --opt,arg1,--opt-value,arg2
    args before reordering: arg1,--opt,--opt-value,arg2
    args after reordering:  --opt,arg2,arg1,--opt-value

After this patch is applied:

    args before reordering: --opt,--opt-value,arg1
    args after reordering:  --opt,--opt-value,arg1
    args before reordering: --opt,--opt-value,arg1,arg2
    args after reordering:  --opt,--opt-value,arg1,arg2
    args before reordering: arg1,--opt,--opt-value,arg2
    args after reordering:  --opt,--opt-value,arg1,arg2

Co-authored-by: lynn (they) <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>

* Fix handling of -- delimiter

If a `--` delimiter is encountered, any remaining _non-option-value_
arguments must be handled as argument.

From the POSIX spec (emphasis mine)
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html#tag_12_0):

> The first -- argument that *is not an option-argument* should be accepted
> as a delimiter indicating the end of options. Any following arguments
> should be treated as operands, even if they begin with the '-' character.

There was a corner-case scenario, where a `--flag` followed by a `--` did
not use `--` as value for the flag, but instead considered it as delimiter.

As a result;

    foo test arg1 --opt -- arg2

Would be reordered as:

   foo test --opt arg1 arg2

Which caused `arg1` to be used as value for `--opt`, instead of `--`,
which is the actual value.

Signed-off-by: Sebastiaan van Stijn <[email protected]>

Co-authored-by: Sebastiaan van Stijn <[email protected]>
Co-authored-by: lynn (they) <[email protected]>
    @meatballhat @thaJeztah @coilysiren
    3 people authored Apr 21, 2022
    Configuration menu
    Copy the full SHA
    b963ddc View commit details
    Browse the repository at this point in the history
Loading