Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: urfave/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.11.0
Choose a base ref
...
head repository: urfave/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.11.1
Choose a head ref
  • 14 commits
  • 7 files changed
  • 6 contributors

Commits on Oct 30, 2015

  1. Do not return error when flag parsing should be skipped 

    Signed-off-by: Nathan LeClaire <[email protected]>
    @nathanleclaire @jszwedko
    nathanleclaire authored and jszwedko committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    c538c37 View commit details
    Browse the repository at this point in the history

  2. Actually skip parsing of flags if SkipFlagParsing is set 

    Previous just skipped if firstFlagIndex was > -1
    @jszwedko
    jszwedko committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    bc3cb33 View commit details
    Browse the repository at this point in the history

  3. When skipping flag parsing, still parse into arguments 

    Fool the FlagSet into thinking that all arguments are actually
arguments rather than attempting to parse them as flags.
    @jszwedko
    jszwedko committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    6191d93 View commit details
    Browse the repository at this point in the history

  4. Update TestCommandIgnoreFlagsIncludingFirstArgument to test for argum… 

    …ents
    @jszwedko
    jszwedko committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    8cd49b1 View commit details
    Browse the repository at this point in the history

  5. Use a test table and add --help test 

    Signed-off-by: Nathan LeClaire <[email protected]>
    @nathanleclaire @jszwedko
    nathanleclaire authored and jszwedko committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    3323ab4 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2015

  1. Merge pull request #283 from codegangsta/really-skip-flag-parsing 

    Really skip flag parsing
    @jszwedko
    jszwedko committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    0302d39 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2015

  1. test: avoid output from "go test" when tests pass 

    Some tests where printing to os.Stdout as a side effect even if the
output was not used/checked in the test.
    @osocurioso
    osocurioso committed Nov 28, 2015
    Configuration menu
    Copy the full SHA
    7b94fd3 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2015

  1. Merge pull request #304 from osocurioso/silence-tests 

    test: avoid output from "go test" when tests pass
    @jszwedko
    jszwedko committed Dec 12, 2015
    Configuration menu
    Copy the full SHA
    a3c75bc View commit details
    Browse the repository at this point in the history

  2. Run check completion before error checking 

    Running check completion before error checking allows for completion of flags when no character has been typed yet
    Jacopo committed Dec 12, 2015
    Configuration menu
    Copy the full SHA
    4a8406a View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2015

  1. Merge pull request #309 from dedalusj/check-completion-order 

    Run check completion before error checking
    @jszwedko
    jszwedko committed Dec 13, 2015
    Configuration menu
    Copy the full SHA
    b5232bb View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2015

  1. Export cli.Flag.GetName (previously cli.Flag.getName)

    @Jille
    Jille committed Dec 15, 2015
    Configuration menu
    Copy the full SHA
    f101a00 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2015

  1. use path.Base in Name & HelpName as default values

    @ysh7
    ysh7 committed Dec 18, 2015
    Configuration menu
    Copy the full SHA
    b0b9bd5 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2015

  1. Merge pull request #312 from ysh7/master 

    use path.Base in Name & HelpName as default values
    @jszwedko
    jszwedko committed Dec 21, 2015
    Configuration menu
    Copy the full SHA
    8eb7738 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #311 from Jille/exportFlagNames 

    Export cli.Flag.GetName (previously cli.Flag.getName)
    @jszwedko
    jszwedko committed Dec 21, 2015
    Configuration menu
    Copy the full SHA
    c31a797 View commit details
    Browse the repository at this point in the history
Loading