Repository navigation
Commit 4ddd242
committed
fix: let a user flag named help reach the action
checkHelp looked up the names of the global HelpFlag, so it also matched
user flags that took those names. A user flag named help, which #2174
asks to be able to call, still showed the built-in help instead of
running the action, and so did a user bool -h flag:
foo --help # user help flag: built-in help, action not run
foo -h # user bool -h flag: built-in help, action not run
Keep the help flag that ensureHelp adds and check only that one, as
checkVersion does with the version flag. When a user flag takes help or
-h, the action now runs with that flag set.
Assisted-by: claude:claude-opus-5-5
Signed-off-by: Eng Zer Jun <[email protected]>1 parent f8edc15 commit 4ddd242
3 files changed
Lines changed: 25 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| 166 | + | |
| 167 | + | |
166 | 168 | | |
167 | 169 | | |
168 | 170 | | |
| |||
182 | 184 | | |
183 | 185 | | |
184 | 186 | | |
185 | | - | |
| 187 | + | |
186 | 188 | | |
187 | 189 | | |
188 | 190 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
| 260 | + | |
260 | 261 | | |
261 | 262 | | |
262 | 263 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4110 | 4110 | | |
4111 | 4111 | | |
4112 | 4112 | | |
| 4113 | + | |
4113 | 4114 | | |
4114 | 4115 | | |
4115 | 4116 | | |
4116 | 4117 | | |
4117 | 4118 | | |
4118 | 4119 | | |
| 4120 | + | |
4119 | 4121 | | |
4120 | 4122 | | |
4121 | 4123 | | |
4122 | 4124 | | |
4123 | 4125 | | |
4124 | 4126 | | |
| 4127 | + | |
4125 | 4128 | | |
| 4129 | + | |
4126 | 4130 | | |
4127 | 4131 | | |
4128 | 4132 | | |
| |||
4131 | 4135 | | |
4132 | 4136 | | |
4133 | 4137 | | |
4134 | | - | |
4135 | | - | |
4136 | 4138 | | |
4137 | 4139 | | |
4138 | 4140 | | |
4139 | 4141 | | |
4140 | 4142 | | |
4141 | 4143 | | |
4142 | 4144 | | |
| 4145 | + | |
4143 | 4146 | | |
4144 | 4147 | | |
4145 | | - | |
| 4148 | + | |
4146 | 4149 | | |
4147 | 4150 | | |
4148 | | - | |
4149 | | - | |
| 4151 | + | |
| 4152 | + | |
| 4153 | + | |
| 4154 | + | |
4150 | 4155 | | |
4151 | 4156 | | |
4152 | 4157 | | |
| 4158 | + | |
4153 | 4159 | | |
4154 | 4160 | | |
4155 | | - | |
| 4161 | + | |
| 4162 | + | |
| 4163 | + | |
| 4164 | + | |
| 4165 | + | |
| 4166 | + | |
| 4167 | + | |
| 4168 | + | |
4156 | 4169 | | |
4157 | 4170 | | |
4158 | 4171 | | |
| |||
4163 | 4176 | | |
4164 | 4177 | | |
4165 | 4178 | | |
4166 | | - | |
4167 | | - | |
4168 | | - | |
| 4179 | + | |
4169 | 4180 | | |
4170 | 4181 | | |
4171 | 4182 | | |
| |||
4175 | 4186 | | |
4176 | 4187 | | |
4177 | 4188 | | |
4178 | | - | |
| 4189 | + | |
4179 | 4190 | | |
4180 | 4191 | | |
4181 | 4192 | | |
| |||
0 commit comments