Conversation
|
you may want to check against any of these tests that are relevant: https://github.com/cloudpipe/cloudpickle/blob/343da119685f622da2d1658ef7b3e2516a01817f/tests/cloudpickle_test.py#L1170 |
8730f98 to
af11bbe
Compare
|
Can you give a short summary of what you feel is done and what is left to do? I'm heading toward a release, and trying to get some nagging issues/PRs tied up. I'll help with this if possible. |
3ba68e0 to
17085c1
Compare
17085c1 to
4cc7567
Compare
|
@mmckerns Status update
I don't think anything that previously worked would be broken by these changes, but I have not confirmed that ABC classes failed to pickle in python <= 3.6 |
|
@mmckerns @emfdavid Take a look at https://github.com/anivegesana/dill/tree/issue_332_abc_data and see if it is going in the direction that you want it. |
@anivegesana: Yeah, this is a good direction. |
|
@emfdavid Bump |
|
@anivegesana: feel free to assume the answer is yes, as opposed to waiting. |
|
Very cool @anivegesana - 2ce1c9e looks really good. |
…een lost in rebase.
Resolves #332
Register ABCMeta to use StockPickler. If workable, this is preferable to the cloudpickle solution that depends heavily on the internals of the ABC implementation.
This will remain broken on some versions of Python 3.7 that did not support pickling the new c implementation of ABC.
Issues: