Skip to content

fix: accept port in oci reference name #6864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olblak merged 4 commits into from
Nov 22, 2025
Merged

fix: accept port in oci reference name #6864

olblak merged 4 commits into from
Nov 22, 2025

Conversation

@olblak
Copy link
Member

@olblak olblak commented Nov 21, 2025

Fix #6862

Correctly handle docker image name that contain port such as "registry.service.consul:5000/container/redis:8.4.0"

Test

To test this pull request, you can run the following commands:

cd pkg/plugins/resources/dockerimage
go test .

Additional Information

Checklist

  • I have updated the documentation via pull request in website repository.

Tradeoff

Potential improvement

@olblak olblak added bug Something isn't working resource-dockerdigest Resource of kind dockerDigest resource-docker Resource of kind Docker Image resource-dockerfile Resource of kind Dockerfile labels Nov 21, 2025
@olblak olblak mentioned this pull request Nov 21, 2025
Closed
@olblak
Copy link
Member Author

olblak commented Nov 21, 2025 •
edited
Loading

Have you tried the changes in the PR #6864 ?

I just provision a zot registry running

 docker run -i -t --rm -p 5000:5000 ghcr.io/project-zot/zot-linux-amd64:latest

Then I pushed a local tag

docker tag alpine:3.22.1 localhost:5000/alpine:3.22.1
docker push localhost:5000/alpine:3.22.1

And then running updatecli works as expected

source: default
---------------

Searching for version matching pattern ">=3.22.1"
✔ Docker Image Tag "3.22.1" found matching pattern ">=3.22.1"

source: default-digest
----------------------

✔ Docker Image Tag localhost:5000/alpine:3.22.1 resolved to digest localhost:5000/alpine:3.22.1@sha256:7b9b6a044d921dfcaea2a843ff19d725948590352198f93cb878fd2c19d7ba3c

@olblak olblak enabled auto-merge (squash) November 22, 2025 07:37
@olblak olblak disabled auto-merge November 22, 2025 10:28
@olblak olblak enabled auto-merge (squash) November 22, 2025 10:28
@olblak olblak merged commit b91ae91 into updatecli:main Nov 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working resource-docker Resource of kind Docker Image resource-dockerdigest Resource of kind dockerDigest resource-dockerfile Resource of kind Dockerfile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Autodiscovery / support private registry which is running on non default https port (443) but e.g. 5000

1 participant

@olblak