Skip to content

fix: Correctly set default action title based on pipeline title #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olblak merged 1 commit into from
Nov 7, 2025
Merged

fix: Correctly set default action title based on pipeline title #6610

olblak merged 1 commit into from
Nov 7, 2025

Conversation

@olblak
Copy link
Member

@olblak olblak commented Nov 7, 2025 •
edited
Loading

While investigating #6607 I noticed that the action object would drop the change done a few line aboves
So this line is not needed

Test

I test this change with an action that doesn't content a title such as

  actions:
    default:
      kind: github/pullrequest
      spec:
        automerge: false
        labels:
          - chore
          - skip-changelog
      scmid: default

Additional Information

Checklist

  • I have updated the documentation via pull request in website repository.

Tradeoff

Potential improvement

@olblak olblak added the bug Something isn't working label Nov 7, 2025
@olblak olblak changed the title fix: don't reset action object fix: Correctly set default action title based on pipeline title Nov 7, 2025
@olblak olblak enabled auto-merge (squash) November 7, 2025 20:55
@olblak olblak requested a review from Copilot November 7, 2025 20:55
Copilot AI reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the RunActions() function where the action.Scm assignment was being inadvertently discarded.

  • Removes a redundant line that was overwriting the local action variable after the SCM had been assigned to it

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@olblak olblak merged commit 6cdb4de into updatecli:main Nov 7, 2025
11 checks passed
@olblak olblak mentioned this pull request Nov 8, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@olblak