-
-
Notifications
You must be signed in to change notification settings - Fork 108
bug: various Updatecli console output improvement #6460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Olblak <[email protected]>
Signed-off-by: Olblak <[email protected]>
* Display git repository information * Display various information as resource headers * Fix action title ordering * Correctly initiate result data Signed-off-by: Olblak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request enhances the Updatecli console output to improve readability and reduce clutter during pipeline execution. The changes reorganize how information is presented, move verbose changelog output to debug level, and add contextual headers showing repository details and execution mode.
- Moved changelog diff output from info to debug level to reduce verbosity
- Added repository and dry-run status headers for each resource execution (source/condition/target/actions)
- Removed duplicate error logging by consolidating error messages
- Fixed pipeline report data initialization to use pointers correctly
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
pkg/plugins/scms/*/summary.go |
Implements Summary() method for SCM providers to display repository context |
pkg/plugins/scms/*/summary_test.go |
Adds test coverage for the new Summary() methods |
pkg/plugins/resources/go/gomod/version.go |
Removes duplicate error logging, consolidates error messages |
pkg/core/pipeline/main.go |
Adds repository headers and initializes report data with SCM information |
pkg/core/pipeline/actions.go |
Restructures action output display with repository context |
pkg/core/pipeline/targets.go |
Moves changelog output to debug level, simplifies error messages |
pkg/core/reports/main.go |
Updates report template to include repository information per resource |
pkg/core/pipeline/scm/main.go |
Adds Summary() method to ScmHandler interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
… into refactor/console/output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This pull request introduces various minor changes to the console output to better understand the different pipeline execution by:.
Please note that this PR requires #6422 as it introduces the githubsearch scm
Before
After
Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
Potential improvement