chore(deps): update aws-sdk-go library to v2 #6021
Conversation
Signed-off-by: Olblak <[email protected]>
olblak
added
dependencies
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the AWS SDK from the legacy aws-sdk-go v1 to the newer aws-sdk-go-v2 as part of maintenance since the v1 SDK is out of maintenance.
- Updates all AWS SDK imports to use v2 packages
- Refactors client initialization to use the new v2 configuration pattern
- Updates type definitions and function signatures to match v2 API changes
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/plugins/resources/awsami/sort.go | Updates type definitions from pointer slices to value slices for Image types |
| pkg/plugins/resources/awsami/main.go | Major refactor of client initialization and configuration using v2 patterns |
| pkg/plugins/resources/awsami/helpers.go | Updates error handling and type access patterns for v2 compatibility |
| pkg/plugins/resources/awsami/data_test.go | Updates test mocks and data structures to match v2 API |
| pkg/plugins/resources/awsami/condition_test.go | Updates test assertions and adds required enum values for v2 types |
| go.mod | Adds v2 SDK dependencies and removes v1 dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Olblak <[email protected]>
Signed-off-by: Olblak <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
As a user, have not seen any regression so far on https://github.com/jenkins-infra/packer-images/ neither on https://github.com/jenkins-infra/terraform-aws-sponsorship
|
Thank you very much for testing |
2 participants
The golang library
aws-sdk-gois out of maintenance so this pullrequest upgrade toaws-sdk-go-v2as explained from https://docs.aws.amazon.com/sdk-for-go/v2/developer-guide/migrate-gosdk.htmlTest
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
Potential improvement