You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 18, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Mar 18, 2024. It is now read-only.
What do you recommend as a catch all alternative? Perhaps allow passing the signature implementation to the signer method and a default overload with the current implementation?
That is a nice fallback/advanced possibility. However the suffix list is quite easily exhausted, so you might also choose to handle EC as an exception:
Well, the JDK signature API is extensible and might extend to other implementations too. Can I safely assume that other then EC, all implementations have an exact corresponding SHA256with + implementation counterpart?
I don't think we can rely on that. But my thoughts are to either make the "auto-algorithm" robust enough to at support all standard ciphers (it's not far from that), or don't offer it at all and make the user always supply the algorithm name. (Which loses convenience.)
Yes, I would support offering both with overloading.
It's correct that we need that on verify time as well, but won't the developer of the launcher know exactly what kind of key the provider of the business app config used? (I mean, they have to exchange the key, so why not also exchange its properties? It is usually also determinable from the beginning of the key string.)
We could also write that algorithm as an argument of the configuration XML for piece of mind.
Activity
mordechaim commentedon Mar 18, 2020
What do you recommend as a catch all alternative? Perhaps allow passing the signature implementation to the signer method and a default overload with the current implementation?
hinca commentedon Mar 18, 2020
That is a nice fallback/advanced possibility. However the suffix list is quite easily exhausted, so you might also choose to handle EC as an exception:
https://docs.oracle.com/en/java/javase/14/docs/specs/security/standard-names.html#signature-algorithms
(Sorry for fat fingers, closed by accident.)
mordechaim commentedon Mar 18, 2020
Well, the JDK signature API is extensible and might extend to other implementations too. Can I safely assume that other then EC, all implementations have an exact corresponding
SHA256with + implementationcounterpart?hinca commentedon Mar 18, 2020
I don't think we can rely on that. But my thoughts are to either make the "auto-algorithm" robust enough to at support all standard ciphers (it's not far from that), or don't offer it at all and make the user always supply the algorithm name. (Which loses convenience.)
mordechaim commentedon Mar 18, 2020
Or go between the lines and offer both.
mordechaim commentedon Mar 18, 2020
The problem is that when we verify we also need the exact same algorithm used, and it gets tricky to pass around the user-provided algorithm.
hinca commentedon Mar 18, 2020
Yes, I would support offering both with overloading.
It's correct that we need that on verify time as well, but won't the developer of the launcher know exactly what kind of key the provider of the business app config used? (I mean, they have to exchange the key, so why not also exchange its properties? It is usually also determinable from the beginning of the key string.)
We could also write that algorithm as an argument of the configuration XML for piece of mind.
mordechaim commentedon Mar 30, 2020
I think I'll stick to simply check if algorithm is
ECand append"DSA". If it will be requested otherwise I'll think of an advanced solution then.Fix Elliptic Curve inconsistency, #89