Repository navigation
Conversation
Values just below a million or a billion round up to 1000.0 of the smaller unit, so 999,999 printed as 1,000.0K instead of 1.0M.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
unsloth.utils.hf_hub.formatted_intpicks the unit from the raw value and then rounds to one decimal. A value just under a million or a billion picks the smaller unit, then rounds up to 1000.0 of it:Fix
For each unit, check whether the value rounded to one decimal stays below 1000. If it doesn't, move to the next unit. Output for all other values is the same as before. The raw thresholds (
< 1000prints the integer, otherwise K/M/B) are also unchanged.Test
tests/test_hf_hub_formatted_int.pyloadsunsloth/utils/hf_hub.pyby path, so it doesn't import torch or the full package. It checks values around each boundary. The999_999and999_999_999cases fail before the fix and pass after. The other eight pass both before and after.AI assistance: I used an AI coding assistant (Grok Bot) to help find and write this fix. I reviewed the change and ran the test myself.