Repository navigation
Settings contract: read the embedding picker's stacking classes inside cn() too - #12945
Merged
Merged
Conversation
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo tests (CPU, studio)is red on main since8f20a9f3db(#12875), and on every PR built on it (#12913, #12937, #12940):Cause
The test, not #12875. The contract is that the row holding
EmbeddingModelPickerstacks and fills under 360px. #12875 kept exactly those classes on the same row, but moved them from a literalclassName="..."intoclassName={cn("max-[360px]:flex-col max-[360px]:items-stretch max-[360px]:gap-3", notLoaded && "items-end")}to add a conditional class. The test matched the wholeclassName="..."attribute, so it read a row that still stacks as one that does not.Fix
The check looks for the quoted class string itself, which is present both as a plain
classNameand as an argument ofcn(...). The width half of the contract (max-[360px]:w-fullormax-[360px]:flex-1) is unchanged.Verification
tests/studio/test_settings_compact_overflow_contract.py: 1 failed on main (c6cfbb71cc), 5 passed here.max-[360px]:flex-colfrom the row fails it, and so does dropping themax-[360px]:w-fullwidths.