Repository navigation
Frontend test: give the cold Vite SSR render in reasoning-source-render room on a loaded runner - #12903
Merged
Conversation
…er room on a loaded runner
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend unit tests (Windows)fails on PRs that do not touch the chat renderer (#12900 today, and #12875 before it) with:Cause
The test, not the renderer. Each of the two tests in
reasoning-source-render.test.ts(#10717) spawns a Node child that cold-starts a Vite SSR server and transforms the wholemarkdown-text.tsxgraph with no prebundle, under a 30 sexecFiletimeout. That takes about 9 s per test on an idle Linux box. The Windows frontend job runs it alongside ~7,600 other tests, and on #12900 it took 30.2 s, so the child was killed by the timeout and the test failed with no assertion ever evaluated.Fix
Both renders share one
RENDER_TIMEOUT_MS = 120_000. The cap only exists to stop a hung child; what the test checks is the markup, and those assertions are unchanged.Verification
tests/reasoning-source-render.test.ts: 2 passed (about 9 s each locally).MarkdownTextSourcerender nothing fails both tests on this branch, so the change does not weaken what they guard.