Skip to content

Frontend test: give the cold Vite SSR render in reasoning-source-render room on a loaded runner - #12903

Merged
danielhanchen merged 1 commit into
mainfrom
ci/reasoning-source-render-timeout
Oct 7, 2026
Merged

danielhanchen merged 1 commit into
mainfrom
ci/reasoning-source-render-timeout

Conversation

@danielhanchen

Copy link
Copy Markdown
Member

Frontend unit tests (Windows) fails on PRs that do not touch the chat renderer (#12900 today, and #12875 before it) with:

not ok 7651 - source Markdown renders in an assistant root scope without a message part
  duration_ms: 30205.8217
  error: Command failed: node.exe --input-type=module --eval ...

Cause

The test, not the renderer. Each of the two tests in reasoning-source-render.test.ts (#10717) spawns a Node child that cold-starts a Vite SSR server and transforms the whole markdown-text.tsx graph with no prebundle, under a 30 s execFile timeout. That takes about 9 s per test on an idle Linux box. The Windows frontend job runs it alongside ~7,600 other tests, and on #12900 it took 30.2 s, so the child was killed by the timeout and the test failed with no assertion ever evaluated.

Fix

Both renders share one RENDER_TIMEOUT_MS = 120_000. The cap only exists to stop a hung child; what the test checks is the markup, and those assertions are unchanged.

Verification

  • tests/reasoning-source-render.test.ts: 2 passed (about 9 s each locally).
  • Lowering the cap to 3 s, standing in for a slow runner, fails both tests the way CI did; 120 s passes.
  • Sabotage: making MarkdownTextSource render nothing fails both tests on this branch, so the change does not weaken what they guard.

@danielhanchen

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T23:57:10.898424Z 2c5d9d0 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 2c5d9d07a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@unslothai unslothai deleted a comment from chatgpt-codex-connector Bot Oct 7, 2026
@danielhanchen
danielhanchen merged commit 3000d91 into main Oct 7, 2026
@danielhanchen
danielhanchen deleted the ci/reasoning-source-render-timeout branch October 7, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant