Repository navigation
Studio: fill the Hebrew and Swedish strings that left the strict i18n check red on main - #12881
Merged
Merged
Conversation
… check red on main
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run i18n:check:strict(the "Frontend build + bundle sanity" job in studio-frontend-ci.yml) has been failing on main since 6df2e23, so every PR that runs the frontend job goes red on it (#12875, #12876, #12878, #12879 today).Cause
Two merges raced the Hebrew and Swedish catalogs:
en.tsand to the overlays that existed on its base.he.ts(Studio: add Hebrew (he) display language #6344) and the Swedish sandbox fixes (Studio: fix locale parity on main (Swedish sandbox strings, Manage files) #12844) landed on main before it merged, so those two never got the keys. Seven of them are understudio., which the parity check requires to be localized, so this is an error, not a fallback.levelHelp,levelHighDescriptionandlevelLowDescriptionfromen.tsand addedpermissionLabel,levelPickerTitle,levelOff,levelOffShort,levelHighDetail,levelLowDetail.sv.tsstill had the old three, which the check reports as keys that exist in the overlay but not in en.The product was wrong here, not the check: Hebrew and Swedish users saw English for the decision model wizard, validation and progress strings.
Fix
he.ts: the 17 missing keys (decision API model labels and ready state, wizard checkpoint label and tooltip, the two decision validation messages, the three Decision API progress strings, the library "Made with" filter and the audio row).sv.ts: the same 17, plus the six new sandbox keys, and the three removed ones deleted. The two short level labels are brought in line with the reworded English as well.Placeholders match en for every new string (
{model},{columns},{name}).Verification
npm run i18n:check:strict: exit 1 on main, exit 0 on this branch (all 13 overlays pass).npm run typecheckpasses.tests/lazy-locale-loading.test.ts,tests/sandbox-level.test.ts: 43 passed.