Repository navigation
Studio: nudge sidebar row pin and options buttons 3px right - #12563
Conversation
The options button on a hovered chat or project row now sits 3px from the pill's right edge instead of 6px, and the pin moves with it so the gap between them is unchanged. List header actions move by the same 3px so they keep ending where a hovered row's options button does.
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Two reds on head |
#12562 (make carried rows a faintly frosted, darker copy) landed after this branch was cut and restyles the shared ghost rule that #12499 introduced: it relies on --row-ghost-surface and .model-picker-row-ghost, and edits model-picker-pinned-drag-preview.test.ts, all of which the #12499 revert removes. Keeping it without #12499 leaves .sidebar-row-ghost reading an unset variable, so the conflict is resolved by dropping #12562's two hunks as well. It should be re-opened together with #12499. #12563, #12564 and #12597 are kept.
…i#12563) The options button on a hovered chat or project row now sits 3px from the pill's right edge instead of 6px, and the pin moves with it so the gap between them is unchanged. List header actions move by the same 3px so they keep ending where a hovered row's options button does.
Summary
On a hovered chat or project row, the options button and the pin now sit 3px further right, closer to the end of the pill.
Changes
.sidebar-row-actionright padding goes frompr-1.5topr-0.75, so the options glyph ends 3px from the pill's right edge instead of 6px.rightoffset goes from 30px to 27px, so the 2px gap between the pin and the options button is unchanged..sidebar-sticky-labelright padding is 9px (was 12px), and 8px under the desktop titlebar (was 11px).Testing
npm testpasses.tests/sidebar-spinner-column.test.tsandtests/on-device-dot-and-header-alignment.test.tsare updated for the new offsets. The working-row spinner padding and the focus paddings still clear the options button.