Repository navigation
Run bounded project coding tasks in owned worktrees - #10658
Closed
PhilipJohnBasile wants to merge 13 commits into
Closed
PhilipJohnBasile wants to merge 13 commits into
PhilipJohnBasile wants to merge 13 commits into
Conversation
This was referenced Sep 9, 2026
PhilipJohnBasile
marked this pull request as ready for review
September 9, 2026 19:31
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5dde2ca776
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
PhilipJohnBasile
deleted the
codex/project-task-integration-20260909
branch
September 12, 2026 02:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project tasks can now run from the project page through the durable engine and the shared Studio inference loop. A coordinator delegates bounded reviewer/implementer children; every attempt receives an owned Git worktree. The panel exposes status, cancellation, explicit retry, parent/attempt relationships, output and a bounded diff against the starting commit, including new files. Changes remain available for human review.
This PR now includes the durable task engine from #10655 together with its first execution/UI consumer. The engine-only PR is retained as a draft reference, and its duplicate standalone workflow is removed here. Remaining prerequisites are #10633 (lifecycle), #10577 (secure edits), and #10594 (Git/worktrees). CI first checks the standalone source's unavailable-prerequisite response, then composes the exact revisions documented in
studio/docs/project-task-integration.md. The lifecycle and Git PRs carry optional task hooks; this PR checks their protocols before admitting tasks.The runtime snapshot binds the model, provider routing and encrypted credential-row version. Tasks never load a model or substitute a provider. Each model turn respects the attempt allocation and saved provider output-token cap, then releases admission before tools or child waits; local admission retains the aggregate KV budget. A private task-only callback restricts coordinator/reviewer roles to reads and implementers to confined, expected-content edits. Tool results use the shared model-visible cap. Task reads, listings, waits and optional verification commands can repeat identical arguments to observe changed state; ordinary-chat deduplication, one-shot restrictions and all task budgets remain enforced.
Failed setup rolls back a newly created, provably clean owned checkout before execution; dirty or ambiguous checkouts remain in Git recovery. Polling batches worktree bindings in one query. Incompatible prerequisite versions return 503 and permit shutdown. Native project/worktree fences survive revoked database leases and remain held until physical tool workers return. Retirement drains tasks before acquiring Git's exclusive fence.
Optional #10672 command hooks add a default-off capability checkbox, captured opt-in and bounded command-evidence views. Without that separate source layer and a supported Linux supervisor, the capability stays unavailable. Task completion and command success are presented separately. This integration layer does not itself execute commands.
Scope: owned worktrees require POSIX; runtimes are saved tool-capable providers accepting output caps or an already loaded matching GGUF runtime with idle-slot clearing. Subscription endpoints without output caps, safetensors execution, automatic commits/merges, cleanup of bound task worktrees and existing-folder adoption remain outside this layer. Children start from the captured commit. No live-model/GPU quality or performance claim.
Validation:
c27726c496531dcfc59b7a039f1cc05dee74b8c0: Linux, macOS, Windows, and frontend qualification. CI composes lifecycle10eec87e4, confined editsa85723e1c, and Git/worktrees9d86e2547.Current head
94baadc4c42ec88fbf610ac0fa8aefce4b6a0c5achanges only the review guide to match those dependency pins and the upstream budget. All executable source, tests, and workflows are identical to the qualified source head. Maintainer review and prerequisite merges remain separate gates; this does not satisfy #10672's requested rebase onto merged main-branch foundations.