Repository navigation
Add durable project task ownership and bounded execution lanes - #10655
Closed
PhilipJohnBasile wants to merge 2 commits into
Closed
PhilipJohnBasile wants to merge 2 commits into
PhilipJohnBasile wants to merge 2 commits into
Conversation
PhilipJohnBasile
marked this pull request as ready for review
September 9, 2026 18:11
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 9, 2026
Member
|
This adds the task engine and a six-job matrix in .github/workflows/studio-project-tasks-ci.yml but nothing in the tree calls task_runner.py yet. Could you fold it in with its first real consumer so the layer arrives with something exercising it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task engine is now included with its first real execution/UI consumer in #10658, as requested in review. This engine-only PR is retained as a draft for source/history reference; review and land the combined task feature through #10658 after its worktree prerequisites. The combined branch runs engine regressions in its integration matrix and removes this duplicate standalone workflow.
The original engine-only scope and validation receipt follow for traceability:
Background tasks need durable ownership and dedicated child capacity before model and workspace adapters can safely use them. This adds an internal project task store and bounded runner: parents can wait for children while separate child workers continue, interrupted attempts require explicit retries, and late workers cannot publish results after losing ownership.
The layer includes atomic child-count/token reservations, retry caps, immutable snapshots, monotonic events, queued/running lease recovery, cancellation and project-retirement admission fences. Shutdown stops admission and reports workers that have not returned; a child that cannot drain leaves its parent interrupted and its project busy. The executor contract documents the required model-admission release and existing filesystem/process fences.
This is the independently reviewable engine layer requested in #9673. No renderer endpoints, model/tool adapters, owned child-worktree wiring, or UI are added here. It does not advance the held existing-folder PR #9859, replace the aggregate #9987 executor, or claim an end-to-end background coding workflow.
Validation at
191ac8ba86943eb0bd54a9f1532c5d2ed384c6c5:git diff --checkpassed.The first native run exposed a racy assertion that shutdown had already flushed cancellation to SQLite, and the adjacent 900-thread storage fixture exceeded the 30-second Windows budget. The shutdown test now observes the actual cancellation signal. Storage runs with a separate 120-second budget while engine tests retain 30 seconds; no cases are skipped.
The tests cover concurrent claims and budget reservations, both parent workers waiting on children, stale results, explicit retries, shutdown/submission races, project archival/deletion, an executor that does not stop promptly, and preservation of worker capacity after an executor raises SystemExit. Real model, tool-confinement, and packaged-app qualification belong to the following integration layers.