Repository navigation
Display bounded edit requests and results in chat - #10643
PhilipJohnBasile wants to merge 4 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c4deca98e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
This also removes the Always allow button for python and terminal, so anyone using that today will get a prompt on every call, could you confirm that is intended? The edit card itself looks like a useful addition, but it would be easier to review split from the approval policy change. |
PhilipJohnBasile
changed the title
Edit-file calls now have a dedicated chat card showing the requested path and replacements, with distinct results for declined, cancelled, incomplete and failed edits. Malformed streamed arguments remain safe to display. Edits exceeding the complete argument-display limit cannot be approved through buttons, keyboard shortcuts or a remembered allowance; Deny remains visible.
This frontend-only PR is narrowed to edit presentation and its complete-request display guard. Existing Python and terminal “Always allow” behavior is preserved, and the permission-mode copy is unchanged. The broader per-call approval-policy proposal is removed from this diff and retained separately for later discussion. Command execution and supervision are outside this PR.
Current head
be86fdaff6ab29e162e270c285c1916a63e293b3includes upstream08733896d. All 7,292 frontend tests, app/test typechecks, production build, and startup budget passed locally. The branch uses upstream's current bundle limits. The scope remains edit presentation and the complete-request display guard, with existing Python/terminal remembered approvals preserved. No packaged-desktop acceptance is claimed.