Skip to content

Commit 124ca0c

Browse files
committed
ci: try TARGET_CC env instead for new napi-rs
1 parent f10dee5 commit 124ca0c

File tree

5 files changed

+20
-18
lines changed

5 files changed

+20
-18
lines changed

.github/workflows/release-napi.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242

4343
build:
4444
needs: check
45-
if: needs.check.outputs.version_changed == 'true'
45+
# if: needs.check.outputs.version_changed == 'true'
4646
strategy:
4747
fail-fast: false
4848
matrix:
@@ -131,7 +131,7 @@ jobs:
131131
run: ${{ matrix.build }} --target ${{ matrix.target }}
132132
shell: bash
133133
env:
134-
CC: clang # for mimalloc
134+
TARGET_CC: clang # for mimalloc
135135

136136
- name: Upload artifacts
137137
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
@@ -144,7 +144,7 @@ jobs:
144144
145145
build-freebsd:
146146
needs: check
147-
if: needs.check.outputs.version_changed == 'true'
147+
# if: needs.check.outputs.version_changed == 'true'
148148
name: Build FreeBSD
149149
runs-on: ubuntu-latest
150150
steps:
@@ -194,8 +194,10 @@ jobs:
194194
permissions:
195195
id-token: write # for `npm publish --provenance`
196196
needs:
197+
- check
197198
- build
198199
- build-freebsd
200+
if: needs.check.outputs.version_changed == 'true'
199201
steps:
200202
- uses: taiki-e/checkout-action@b13d20b7cda4e2f325ef19895128f7ff735c0b3d # v1.3.1
201203

Cargo.lock

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

napi/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ doctest = false
2222
[dependencies]
2323
unrs_resolver = { workspace = true }
2424

25-
napi = { version = "3.0.0-beta.11", default-features = false, features = ["napi3", "serde-json"] }
26-
napi-derive = { version = "3.0.0-beta.11" }
25+
napi = { version = "3.0.0-beta.12", default-features = false, features = ["napi3", "serde-json"] }
26+
napi-derive = { version = "3.0.0-beta.12" }
2727
tracing-subscriber = { version = "0.3.19", optional = true, default-features = false, features = ["std", "fmt"] } # Omit the `regex` feature
2828

2929
[target.'cfg(not(any(target_os = "linux", target_os = "freebsd", target_arch = "arm", target_family = "wasm")))'.dependencies]

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"napi-postinstall": "^0.3.0"
2929
},
3030
"devDependencies": {
31-
"@napi-rs/cli": "3.0.0-alpha.91",
31+
"@napi-rs/cli": "3.0.0-alpha.92",
3232
"@napi-rs/wasm-runtime": "^0.2.11",
3333
"@types/node": "^22.16.0",
3434
"clean-pkg-json": "^1.3.0",

pnpm-lock.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)