src/usr/local/php/unraid-tailscale-utils/unraid-tailscale-utils/Utils.php (1)

169-182: Excellent centralization of page validation logic.

The new pageChecks() method effectively consolidates readiness validation across multiple pages, reducing code duplication and ensuring consistent behavior.

Optional: Consider caching instances to reduce overhead

If performance becomes a concern, you could cache the Config and LocalAPI instances to avoid recreating them on every call:

 public static function pageChecks(Translator $tr): bool
 {
-    if ( ! (new Config())->Enable) {
+    static $config = null;
+    static $localAPI = null;
+    
+    if ($config === null) {
+        $config = new Config();
+        $localAPI = new LocalAPI();
+    }
+    
+    if ( ! $config->Enable) {
         echo($tr->tr("tailscale_disabled"));
         return false;
     }

-    if ( ! (new LocalAPI())->isReady()) {
+    if ( ! $localAPI->isReady()) {
         echo($tr->tr("warnings.not_ready"));
         return false;
     }

     return true;
 }

Note: Only implement this if profiling shows the current approach is a bottleneck.

src/usr/local/emhttp/plugins/tailscale/locales/en_US.json (1)

105-105: Clear and helpful warning message added.

The new not_ready warning appropriately informs users about the temporary unavailability.

For enhanced user experience, consider implementing an auto-refresh mechanism (e.g., meta refresh tag or JavaScript polling) so users don't need to manually refresh the page. This could be added in a future iteration.

src/usr/local/emhttp/plugins/tailscale/include/Pages/Dashboard.php (1)

34-47: Consider aligning Dashboard validation with other pages.

Unlike Info, Lock, Status, and Tailscale pages which use Utils::pageChecks(), Dashboard implements its own readiness validation. While the logic is correct, this inconsistency creates a maintenance burden and could lead to behavioral drift over time.

Consider refactoring to use a pattern closer to the other pages. Since Dashboard needs to display content rather than early-return, you could separate the checks:

Suggested approach

 $tr = $tr ?? new Translator(PLUGIN_ROOT);
 
 $tailscaleConfig = $tailscaleConfig ?? new Config();
 
-$tailscale_dashboard = "<tr><td>" . $tr->tr("tailscale_disabled") . "</td></tr>";
-
-if ($tailscaleConfig->Enable) {
-    $localAPI = $localAPI ?? new LocalAPI();
-    if ( ! $localAPI->isReady()) {
-        $tailscale_dashboard = "<tr><td>" . $tr->tr("warnings.not_ready") . "</td></tr>";
-    } else {
-        $tailscaleInfo     = $tailscaleInfo ?? new Info($tr);
-        $tailscaleDashInfo = $tailscaleInfo->getDashboardInfo();
-
-        $tailscale_dashboard = Utils::printDash($tr->tr("info.online"), $tailscaleDashInfo->Online);
-        $tailscale_dashboard .= Utils::printDash($tr->tr("info.hostname"), $tailscaleDashInfo->HostName);
-        $tailscale_dashboard .= Utils::printDash($tr->tr("info.dns"), $tailscaleDashInfo->DNSName);
-        $tailscale_dashboard .= Utils::printDash($tr->tr("info.ip"), implode("<br><span class='w26'>&nbsp;</span>", $tailscaleDashInfo->TailscaleIPs));
-    }
+if ( ! $tailscaleConfig->Enable) {
+    $tailscale_dashboard = "<tr><td>" . $tr->tr("tailscale_disabled") . "</td></tr>";
+} elseif ( ! (new LocalAPI())->isReady()) {
+    $tailscale_dashboard = "<tr><td>" . $tr->tr("warnings.not_ready") . "</td></tr>";
+} else {
+    $tailscaleInfo     = $tailscaleInfo ?? new Info($tr);
+    $tailscaleDashInfo = $tailscaleInfo->getDashboardInfo();
+
+    $tailscale_dashboard = Utils::printDash($tr->tr("info.online"), $tailscaleDashInfo->Online);
+    $tailscale_dashboard .= Utils::printDash($tr->tr("info.hostname"), $tailscaleDashInfo->HostName);
+    $tailscale_dashboard .= Utils::printDash($tr->tr("info.dns"), $tailscaleDashInfo->DNSName);
+    $tailscale_dashboard .= Utils::printDash($tr->tr("info.ip"), implode("<br><span class='w26'>&nbsp;</span>", $tailscaleDashInfo->TailscaleIPs));
 }

This flattens the nesting and makes the three states (disabled, not ready, ready) more explicit.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: dkaser
Repo: unraid/unraid-tailscale PR: 66
File: src/usr/local/emhttp/plugins/tailscale/include/Pages/Settings.php:218-218
Timestamp: 2025-11-11T00:22:27.117Z
Learning: In the unraid-tailscale plugin, pages with `Tabs="true"` (like Tailscale.page) and their submenu pages (like Tailscale-1-Settings.page) share the same JavaScript scope. JavaScript functions defined in Tailscale.php are accessible in Settings.php because they load in the same browser context.