Skip to content

fix: remove embedded link from SMB warning #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkaser merged 1 commit into from
Dec 11, 2025
Merged

fix: remove embedded link from SMB warning #84

dkaser merged 1 commit into from
Dec 11, 2025

Conversation

@dkaser
Copy link
Collaborator

@dkaser dkaser commented Dec 11, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Documentation
    • Updated netbios warning message to display SMB settings reference as plain text instead of a hyperlink.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the fix label Dec 11, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 11, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

A locale string in the Tailscale plugin's English translation file has been updated. The netbios warning message was modified to remove an HTML anchor tag, changing from a hyperlinked "SMB settings" reference to plain text.

Changes

Cohort / File(s) Summary
Locale translation update
src/usr/local/emhttp/plugins/tailscale/locales/en_US.json		 Removed HTML anchor markup from netbios warning text; replaced hyperlink reference with plain text

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-file change to a locale/translation file with straightforward string content modification
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/smb-warning
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 786245e and 529664d.

📒 Files selected for processing (1)
  • src/usr/local/emhttp/plugins/tailscale/locales/en_US.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dkaser dkaser merged commit df282dd into trunk Dec 11, 2025
4 of 5 checks passed
@dkaser dkaser deleted the fix/smb-warning branch December 11, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkaser