Skip to content

fix: prettier groups on the settings tab #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkaser merged 1 commit into from
Nov 15, 2025
Merged

fix: prettier groups on the settings tab #69

dkaser merged 1 commit into from
Nov 15, 2025

Conversation

@dkaser
Copy link
Collaborator

@dkaser dkaser commented Nov 15, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Style
    • Updated Settings page layout structure and styling for improved presentation consistency.

@coderabbitai
Copy link

coderabbitai bot commented Nov 15, 2025 •
edited
Loading

Walkthrough

HTML markup restructuring in the Tailscale Settings page component, replacing multiple <h3> heading elements with <table class="unraid"> wrappers across eight sections. Visible text content remains unchanged; only the surrounding HTML structure is modified.

Changes

Cohort / File(s) Change Summary
Tailscale Settings page markup restructuring
src/usr/local/emhttp/plugins/tailscale/include/Pages/Settings.php		 Replaced <h3> headings with <table class="unraid"> elements for sections: system_settings, services, outbound_network, save, restart, diagnostics, reauthenticate, and erase. Text content preserved; styling container changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify all eight section headings are correctly converted with matching text content
  • Confirm table markup consistency and proper <thead>, <tr>, and <td> structure across all replacements
  • Check for any unintended side effects on page layout or styling due to table-based container change

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: prettier groups on the settings tab' directly describes the main change: restructuring HTML markup for visual groupings in the settings page.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/settings-headers
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e849a6a and 96fb415.

📒 Files selected for processing (1)
  • src/usr/local/emhttp/plugins/tailscale/include/Pages/Settings.php (8 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings 
Learnt from: dkaser
Repo: unraid/unraid-tailscale PR: 66
File: src/usr/local/emhttp/plugins/tailscale/include/Pages/Settings.php:218-218
Timestamp: 2025-11-11T00:22:27.117Z
Learning: In the unraid-tailscale plugin, pages with `Tabs="true"` (like Tailscale.page) and their submenu pages (like Tailscale-1-Settings.page) share the same JavaScript scope. JavaScript functions defined in Tailscale.php are accessible in Settings.php because they load in the same browser context.
📚 Learning: 2025-11-11T00:22:27.117Z 
Learnt from: dkaser
Repo: unraid/unraid-tailscale PR: 66
File: src/usr/local/emhttp/plugins/tailscale/include/Pages/Settings.php:218-218
Timestamp: 2025-11-11T00:22:27.117Z
Learning: In the unraid-tailscale plugin, pages with `Tabs="true"` (like Tailscale.page) and their submenu pages (like Tailscale-1-Settings.page) share the same JavaScript scope. JavaScript functions defined in Tailscale.php are accessible in Settings.php because they load in the same browser context.

Applied to files:

  • src/usr/local/emhttp/plugins/tailscale/include/Pages/Settings.php
🧬 Code graph analysis (1)
src/usr/local/emhttp/plugins/tailscale/include/Pages/Settings.php (1)
src/usr/local/php/unraid-tailscale-utils/unraid-tailscale-utils/Info.php (1)
  • tr (66-69)
🔇 Additional comments (1)
src/usr/local/emhttp/plugins/tailscale/include/Pages/Settings.php (1)

59-59: Verify Unraid design pattern for section headers and accessibility implications.

This PR replaces eight <h3> heading elements with <table class="unraid"> markup across all section headers (system_settings, services, outbound_network, save, restart, diagnostics, reauthenticate, erase). While the visual change to use Unraid's table class styling is clear, two concerns need verification:

  1. Accessibility: Replacing semantic heading elements (<h3>) with <table> markup removes heading semantics that screen readers rely on for navigation. If this is Unraid's established pattern for this plugin, that's fine, but it should be confirmed.

  2. Design pattern consistency: Confirm this matches how other Unraid pages/plugins structure section headers—is <table class="unraid"> the intended pattern for grouping sections in this context?

Have you tested this change in the Unraid WebGUI to confirm the headers render and group correctly? Also, please confirm this follows the established pattern used elsewhere in the Unraid plugin ecosystem.

Also applies to: 130-130, 141-141, 186-186, 196-196, 209-209, 224-224, 233-233

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the fix label Nov 15, 2025
@dkaser dkaser merged commit 4b3da44 into trunk Nov 15, 2025
6 checks passed
@dkaser dkaser deleted the fix/settings-headers branch November 15, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkaser