Skip to content

feat(web): copy to webgui repo script docs + wc build options #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zackspear merged 2 commits into from
Mar 28, 2025
Merged

feat(web): copy to webgui repo script docs + wc build options #1287

zackspear merged 2 commits into from
Mar 28, 2025

Conversation

@zackspear
Copy link
Contributor

@zackspear zackspear commented Mar 27, 2025 •
edited
Loading

Per discussion w/ Eli removed the activation code debugger file from the repo. I kept it locally though, hence the .gitignore update. Which means I kept the helper method in the activation code extractor class so I could still use it.

coderabbit also made a good suggestion in the webgui repo where I synced changes from this repo for web-component-extractor so I implemented and tested it. Included via ec29069 (#1287)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 27, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zackspear
fix: web-components-extractor escape shell arguments in find command
ec29069 
- Updated the find command in WebComponentsExtractor to use escapeshellarg for both base path and manifest name to prevent command injection vulnerabilities.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1287/dynamix.unraid.net.plg

@zackspear zackspear merged commit 90a775e into feat/web-copy-to-webgui-repo-script-improvements Mar 28, 2025
8 checks passed
@zackspear zackspear deleted the chore/webgui-repo-sync-clean-up branch March 28, 2025 18:32
zackspear added a commit that referenced this pull request Mar 28, 2025
@zackspear
feat(web): copy to webgui repo script docs + wc build options (#1287)
c78d1c2 
Per discussion w/ Eli removed the activation code debugger file from the
repo. I kept it locally though, hence the `.gitignore` update. Which
means I kept the helper method in the activation code extractor class so
I could still use it.

coderabbit also made a good suggestion in the webgui repo where I synced
changes from this repo for web-component-extractor so I implemented and
tested it. Included via [`ec29069`
(#1287)](ec29069)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elibosley elibosley elibosley approved these changes

@pujitm pujitm Awaiting requested review from pujitm

+1 more reviewer

@mdatelle mdatelle mdatelle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zackspear @mdatelle @elibosley