fix: debounce is too long (#1426)

elibosley · web-flow · commit f12d231e6376 · 2025-06-20T11:07:53.000-04:00
&lt;!-- This is an auto-generated comment: release notes by coderabbit.ai
--&gt;

## Summary by CodeRabbit

- **Refactor**
- Reduced the delay before configuration changes are processed,
resulting in faster response times to configuration updates throughout
the application.

&lt;!-- end of auto-generated comment: release notes by coderabbit.ai --&gt;
diff --git a/api/src/unraid-api/config/api-config.module.ts b/api/src/unraid-api/config/api-config.module.ts
@@ -85,7 +85,7 @@ class ApiConfigPersistence {
             this.migrateFromMyServersConfig();
         }
         await this.persistenceHelper.persistIfChanged(this.filePath, this.config);
-        this.configService.changes$.pipe(debounceTime(500)).subscribe({
+        this.configService.changes$.pipe(debounceTime(25)).subscribe({
             next: async ({ newValue, oldValue, path }) => {
                 if (path.startsWith('api')) {
                     this.logger.verbose(`Config changed: ${path} from ${oldValue} to ${newValue}`);
diff --git a/packages/unraid-api-plugin-connect/src/service/config.persistence.ts b/packages/unraid-api-plugin-connect/src/service/config.persistence.ts
@@ -33,8 +33,7 @@ export class ConnectConfigPersister implements OnModuleInit, OnModuleDestroy {
         this.logger.verbose(`Config path: ${this.configPath}`);
         await this.loadOrMigrateConfig();
         // Persist changes to the config.
-        const HALF_SECOND = 500;
-        this.configService.changes$.pipe(debounceTime(HALF_SECOND)).subscribe({
+        this.configService.changes$.pipe(debounceTime(25)).subscribe({
             next: async ({ newValue, oldValue, path }) => {
                 if (path.startsWith('connect.config')) {
                     this.logger.verbose(`Config changed: ${path} from ${oldValue} to ${newValue}`);
diff --git a/packages/unraid-api-plugin-connect/src/service/connection.service.ts b/packages/unraid-api-plugin-connect/src/service/connection.service.ts
@@ -80,11 +80,10 @@ export class MothershipConnectionService implements OnModuleInit, OnModuleDestro
         if (this.identitySubscription) {
             this.identitySubscription.unsubscribe();
         }
-        const debounceTimeMs = 100;
         this.identitySubscription = this.configService.changes$
             .pipe(
                 filter((change) => Object.values(this.configKeys).includes(change.path)),
-                debounceTime(debounceTimeMs)
+                debounceTime(25)
             )
             .subscribe({
                 next: () => {
diff --git a/packages/unraid-api-plugin-generator/src/templates/config.persistence.ts b/packages/unraid-api-plugin-generator/src/templates/config.persistence.ts
@@ -42,8 +42,7 @@ export class PluginNameConfigPersister implements OnModuleInit {
     }
 
     // Automatically persist changes to the config file after a short delay.
-    const HALF_SECOND = 500;
-    this.configService.changes$.pipe(debounceTime(HALF_SECOND)).subscribe({
+    this.configService.changes$.pipe(debounceTime(25)).subscribe({
       next: ({ newValue, oldValue, path: changedPath }) => {
         // Only persist if the change is within this plugin's config namespace
         if (changedPath.startsWith("plugin-name.") && newValue !== oldValue) {

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ class ApiConfigPersistence {`
`85`	`85`	`this.migrateFromMyServersConfig();`
`86`	`86`	`}`
`87`	`87`	`await this.persistenceHelper.persistIfChanged(this.filePath, this.config);`
`88`		`- this.configService.changes$.pipe(debounceTime(500)).subscribe({`
	`88`	`+ this.configService.changes$.pipe(debounceTime(25)).subscribe({`
`89`	`89`	`next: async ({ newValue, oldValue, path }) => {`
`90`	`90`	`if (path.startsWith('api')) {`
`91`	`91`	this.logger.verbose(`Config changed: ${path} from ${oldValue} to ${newValue}`);
Original file line number	Diff line number	Diff line change
`@@ -80,11 +80,10 @@ export class MothershipConnectionService implements OnModuleInit, OnModuleDestro`
`80`	`80`	`if (this.identitySubscription) {`
`81`	`81`	`this.identitySubscription.unsubscribe();`
`82`	`82`	`}`
`83`		`- const debounceTimeMs = 100;`
`84`	`83`	`this.identitySubscription = this.configService.changes$`
`85`	`84`	`.pipe(`
`86`	`85`	`filter((change) => Object.values(this.configKeys).includes(change.path)),`
`87`		`- debounceTime(debounceTimeMs)`
	`86`	`+ debounceTime(25)`
`88`	`87`	`)`
`89`	`88`	`.subscribe({`
`90`	`89`	`next: () => {`
Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,7 @@ export class PluginNameConfigPersister implements OnModuleInit {`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`// Automatically persist changes to the config file after a short delay.`
`45`		`- const HALF_SECOND = 500;`
`46`		`- this.configService.changes$.pipe(debounceTime(HALF_SECOND)).subscribe({`
	`45`	`+ this.configService.changes$.pipe(debounceTime(25)).subscribe({`
`47`	`46`	`next: ({ newValue, oldValue, path: changedPath }) => {`
`48`	`47`	`// Only persist if the change is within this plugin's config namespace`
`49`	`48`	`if (changedPath.startsWith("plugin-name.") && newValue !== oldValue) {`