fix: remove usage of Role.UPC

elibosley · elibosley · commit d1e2f6e0b391 · 2025-01-08T14:47:47.000-05:00
diff --git a/api/src/unraid-api/auth/auth.service.spec.ts b/api/src/unraid-api/auth/auth.service.spec.ts
@@ -22,7 +22,7 @@ describe('AuthService', () => {
         id: '10f356da-1e9e-43b8-9028-a26a645539a6',
         name: 'Test API Key',
         description: 'Test API Key Description',
-        roles: [Role.GUEST, Role.UPC],
+        roles: [Role.GUEST, Role.CONNECT],
         createdAt: new Date().toISOString(),
     };
 
@@ -39,7 +39,7 @@ describe('AuthService', () => {
         id: '-1',
         description: 'Test User',
         name: 'test_user',
-        roles: [Role.GUEST, Role.UPC],
+        roles: [Role.GUEST, Role.CONNECT],
     };
 
     beforeEach(async () => {
@@ -134,13 +134,13 @@ describe('AuthService', () => {
 
             const mockApiKeyWithoutRole = {
                 ...mockApiKey,
-                roles: [Role.UPC],
+                roles: [Role.ADMIN],
             };
 
             vi.spyOn(apiKeyService, 'findById').mockResolvedValue(mockApiKeyWithoutRole);
             vi.spyOn(apiKeyService, 'findByIdWithSecret').mockResolvedValue({
                 ...mockApiKeyWithSecret,
-                roles: [Role.UPC],
+                roles: [Role.ADMIN],
             });
             vi.spyOn(apiKeyService, 'saveApiKey').mockResolvedValue();
             vi.spyOn(authzService, 'addRoleForUser').mockResolvedValue(true);
@@ -152,7 +152,7 @@ describe('AuthService', () => {
             expect(apiKeyService.findByIdWithSecret).toHaveBeenCalledWith(apiKeyId);
             expect(apiKeyService.saveApiKey).toHaveBeenCalledWith({
                 ...mockApiKeyWithSecret,
-                roles: [Role.UPC, role],
+                roles: [Role.ADMIN, role],
             });
             expect(authzService.addRoleForUser).toHaveBeenCalledWith(apiKeyId, role);
         });
diff --git a/api/src/unraid-api/auth/auth.service.ts b/api/src/unraid-api/auth/auth.service.ts
@@ -220,9 +220,9 @@ export class AuthService {
         this.logger.debug('getSessionUser called!');
         return {
             id: '-1',
-            description: 'UPC service account',
-            name: 'upc',
-            roles: [Role.UPC],
+            description: 'Session receives administrator permissions',
+            name: 'admin',
+            roles: [Role.ADMIN],
         };
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -220,9 +220,9 @@ export class AuthService {`
`220`	`220`	`this.logger.debug('getSessionUser called!');`
`221`	`221`	`return {`
`222`	`222`	`id: '-1',`
`223`		`- description: 'UPC service account',`
`224`		`- name: 'upc',`
`225`		`- roles: [Role.UPC],`
	`223`	`+ description: 'Session receives administrator permissions',`
	`224`	`+ name: 'admin',`
	`225`	`+ roles: [Role.ADMIN],`
`226`	`226`	`};`
`227`	`227`	`}`
`228`	`228`	`}`