feat(web): copy to webgui repo script docs + wc build options (#1287)

zackspear · web-flow · commit 90a775eb148d · 2025-03-28T11:32:52.000-07:00
Per discussion w/ Eli removed the activation code debugger file from the repo. I kept it locally though, hence the `.gitignore` update. Which means I kept the helper method in the activation code extractor class so I could still use it. coderabbit also made a good suggestion in the webgui repo where I synced changes from this repo for web-component-extractor so I implemented and tested it. Included via [`ec29069` (#1287)](ec29069)
diff --git a/.gitignore b/.gitignore
@@ -103,3 +103,6 @@ result-*
 
 # Webgui sync script helpers
 web/scripts/.sync-webgui-repo-*
+
+# Activation code data
+plugin/source/dynamix.unraid.net/usr/local/emhttp/plugins/dynamix.my.servers/data/activation-data.php
diff --git a/plugin/source/dynamix.unraid.net/usr/local/emhttp/plugins/dynamix.my.servers/data/activation-data.php b/plugin/source/dynamix.unraid.net/usr/local/emhttp/plugins/dynamix.my.servers/data/activation-data.php
diff --git a/plugin/source/dynamix.unraid.net/usr/local/emhttp/plugins/dynamix.my.servers/include/activation-code-extractor.php b/plugin/source/dynamix.unraid.net/usr/local/emhttp/plugins/dynamix.my.servers/include/activation-code-extractor.php
@@ -153,8 +153,6 @@ public function getPartnerUrl(): string {
 
     /**
      * Output for debugging
-     * 
-     * @see https://tower.local/plugins/dynamix.my.servers/data/activation-data.php
      * @return void
      */
     public function debug(): void {
diff --git a/plugin/source/dynamix.unraid.net/usr/local/emhttp/plugins/dynamix.my.servers/include/web-components-extractor.php b/plugin/source/dynamix.unraid.net/usr/local/emhttp/plugins/dynamix.my.servers/include/web-components-extractor.php
@@ -13,7 +13,9 @@ public function __construct() {}
     private function findManifestFiles(string $manifestName): array
     {
         $basePath = '/usr/local/emhttp' . self::PREFIXED_PATH;
-        $command = "find {$basePath} -name {$manifestName}";
+        $escapedBasePath = escapeshellarg($basePath);
+        $escapedManifestName = escapeshellarg($manifestName);
+        $command = "find {$escapedBasePath} -name {$escapedManifestName}";
         exec($command, $files);
         return $files;
     }
diff --git a/plugin/source/dynamix.unraid.net/usr/local/emhttp/plugins/dynamix.my.servers/scripts/activation_code_remove b/plugin/source/dynamix.unraid.net/usr/local/emhttp/plugins/dynamix.my.servers/scripts/activation_code_remove
@@ -128,7 +128,6 @@ if [[ -f "$ACTIVATION_SETUP_FLAG" ]]; then
   if [[ $DRY_RUN == false ]]; then
     debug_echo "Deleting activation code related setup and php files"
     FILES_TO_DELETE=(
-      "/usr/local/emhttp/plugins/dynamix.my.servers/data/activation-data.php"
       "/usr/local/emhttp/plugins/dynamix.my.servers/include/activation-code-extractor.php"
       "/usr/local/emhttp/plugins/dynamix.my.servers/include/partner-logo.php"
       "/usr/local/emhttp/plugins/dynamix.my.servers/include/welcome-modal.php"

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,9 @@ public function __construct() {}`
`13`	`13`	`private function findManifestFiles(string $manifestName): array`
`14`	`14`	`{`
`15`	`15`	`$basePath = '/usr/local/emhttp' . self::PREFIXED_PATH;`
`16`		`- $command = "find {$basePath} -name {$manifestName}";`
	`16`	`+ $escapedBasePath = escapeshellarg($basePath);`
	`17`	`+ $escapedManifestName = escapeshellarg($manifestName);`
	`18`	`+ $command = "find {$escapedBasePath} -name {$escapedManifestName}";`
`17`	`19`	`exec($command, $files);`
`18`	`20`	`return $files;`
`19`	`21`	`}`