feat: consistent type imports

elibosley · elibosley · commit 6e2b3fa99581 · 2025-06-18T09:15:03.000-04:00
diff --git a/unraid-ui/eslint.config.ts b/unraid-ui/eslint.config.ts
@@ -1,13 +1,16 @@
 import eslint from '@eslint/js';
-// @ts-ignore-error No Declaration For This Plugin
+// @ts-expect-error No Declaration For This Plugin
 import importPlugin from 'eslint-plugin-import';
 import noRelativeImportPaths from 'eslint-plugin-no-relative-import-paths';
 import prettier from 'eslint-plugin-prettier';
 import vuePlugin from 'eslint-plugin-vue';
 import tseslint from 'typescript-eslint';
+// Import vue-eslint-parser as an ESM import
+import vueEslintParser from 'vue-eslint-parser';
 
 // Common rules shared across file types
 const commonRules = {
+  '@typescript-eslint/consistent-type-imports': ['error', { prefer: 'type-imports' }],
   '@typescript-eslint/no-unused-vars': ['off'],
   'no-multiple-empty-lines': ['error', { max: 1, maxBOF: 0, maxEOF: 1 }],
   'no-relative-import-paths/no-relative-import-paths': [
@@ -120,7 +123,7 @@ export default [
   {
     files: ['**/*.vue'],
     languageOptions: {
-      parser: require('vue-eslint-parser'),
+      parser: vueEslintParser,
       parserOptions: {
         ...commonLanguageOptions,
         parser: tseslint.parser,
@@ -146,6 +149,10 @@ export default [
   
   // Ignores
   {
-    ignores: ['src/graphql/generated/client/**/*'],
+    ignores: [
+      'src/graphql/generated/client/**/*',
+      'src/global.d.ts',
+      'eslint.config.ts',
+    ],
   },
 ];
diff --git a/unraid-ui/src/components/common/badge/badge.variants.ts b/unraid-ui/src/components/common/badge/badge.variants.ts
@@ -1,4 +1,5 @@
-import { cva, VariantProps } from 'class-variance-authority';
+import type { VariantProps } from 'class-variance-authority';
+import { cva } from 'class-variance-authority';
 
 export const badgeVariants = cva(
   'inline-flex items-center rounded-full font-semibold leading-none transition-all duration-200 ease-in-out unraid-ui-badge-test',
diff --git a/unraid-ui/src/components/common/button/button.variants.ts b/unraid-ui/src/components/common/button/button.variants.ts
@@ -1,4 +1,5 @@
-import { cva, VariantProps } from 'class-variance-authority';
+import type { VariantProps } from 'class-variance-authority';
+import { cva } from 'class-variance-authority';
 
 export const buttonVariants = cva(
   'inline-flex items-center justify-center rounded-md text-base font-medium ring-offset-background transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:pointer-events-none disabled:opacity-50',
diff --git a/unraid-ui/src/components/common/dialog/Dialog.vue b/unraid-ui/src/components/common/dialog/Dialog.vue
@@ -1,5 +1,6 @@
 <script setup lang="ts">
-import { DialogRoot, useForwardPropsEmits, type DialogRootEmits, type DialogRootProps } from 'reka-ui';
+import { DialogRoot, useForwardPropsEmits } from 'reka-ui';
+import type { DialogRootEmits, DialogRootProps } from 'reka-ui';
 
 const props = defineProps<DialogRootProps>();
 const emits = defineEmits<DialogRootEmits>();
diff --git a/unraid-ui/src/components/common/sheet/sheet.variants.ts b/unraid-ui/src/components/common/sheet/sheet.variants.ts
@@ -1,4 +1,5 @@
-import { cva, VariantProps } from 'class-variance-authority';
+import type { VariantProps } from 'class-variance-authority';
+import { cva } from 'class-variance-authority';
 
 export const sheetVariants = cva(
   'fixed z-50 bg-background gap-4 shadow-lg transition ease-in-out data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:duration-300 data-[state=open]:duration-500 border-border',
diff --git a/unraid-ui/src/types/badge.ts b/unraid-ui/src/types/badge.ts
@@ -1,4 +1,4 @@
-import { badgeVariants } from '@/components/common/badge/badge.variants';
+import type { badgeVariants } from '@/components/common/badge/badge.variants';
 import type { VariantProps } from 'class-variance-authority';
 import type { Component } from 'vue';
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { badgeVariants } from '@/components/common/badge/badge.variants';`
	`1`	`+import type { badgeVariants } from '@/components/common/badge/badge.variants';`
`2`	`2`	`import type { VariantProps } from 'class-variance-authority';`
`3`	`3`	`import type { Component } from 'vue';`
`4`	`4`