chore: minor test cleanup

elibosley · elibosley · commit 3c401bed1b01 · 2025-04-25T09:29:02.000-04:00
diff --git a/api/src/__test__/store/modules/__snapshots__/paths.test.ts.snap b/api/src/__test__/store/modules/__snapshots__/paths.test.ts.snap
@@ -40,47 +40,3 @@ exports[`Returns paths 1`] = `
   "partnerBannerTarget",
 ]
 `;
-
-exports[`Returns paths 2`] = `
-[
-  StringContaining "api/api/src/store/modules",
-  "/usr/local/unraid-api/",
-  StringContaining "api/api/dev/data",
-  "/var/lib/docker/unraid-autostart",
-  "/var/run/docker.sock",
-  StringContaining "api/api/dev/states/parity-checks.log",
-  "/etc/nginx/htpasswd",
-  "/var/run/emhttpd.socket",
-  StringContaining "api/api/dev/states",
-  StringContaining "api/api/dev/dynamix",
-  "/boot/config/plugins/dynamix/case-model.cfg",
-  [
-    StringContaining "api/api/dev/dynamix/default.cfg",
-    StringContaining "api/api/dev/dynamix/dynamix.cfg",
-  ],
-  "/boot/config/plugins/dynamix.my.servers/",
-  StringContaining "api/api/dev/Unraid.net/myservers.cfg",
-  StringContaining "api/api/dev/states/myservers.cfg",
-  "/boot/config/plugins/dynamix.my.servers/env",
-  "./dev/Unraid.net/fb_keepalive",
-  StringContaining "api/api/dev/Unraid.net",
-  StringContaining "api/api/dev/data/machine-id",
-  "/var/log/unraid-api",
-  "/var/log",
-  "/var/run",
-  "./dev/sessions",
-  StringContaining "api/api/dev/keys",
-  StringContaining "api/api/dev/passwd",
-  "/var/run/libvirt/libvirtd.pid",
-  StringContaining "api/api/dev/activation",
-  "/usr/local/emhttp/webGui/images",
-  "/boot/config/ident.cfg",
-  StringContaining "api/api/dev/activation/assets",
-  StringContaining "api/api/dev/activation/assets/logo.svg",
-  "/usr/local/emhttp/webGui/images/partner-logo.svg",
-  StringContaining "api/api/dev/activation/assets/case-model.png",
-  "/usr/local/emhttp/webGui/images/case-model.png",
-  StringContaining "api/api/dev/activation/assets/banner.png",
-  "/usr/local/emhttp/webGui/images/banner.png",
-]
-`;
diff --git a/api/src/unraid-api/graph/resolvers/customization/__snapshots__/customization.service.spec.ts.snap b/api/src/unraid-api/graph/resolvers/customization/__snapshots__/customization.service.spec.ts.snap
diff --git a/api/src/unraid-api/graph/resolvers/customization/customization.service.spec.ts b/api/src/unraid-api/graph/resolvers/customization/customization.service.spec.ts
@@ -143,41 +143,21 @@ describe('CustomizationService', () => {
     });
 
     describe('onModuleInit', () => {
-        it('should initialize paths from store', async () => {
-            await service.onModuleInit();
-            expect((service as any).activationDir).toBe(activationDir);
-            expect((service as any).configFile).toBe(userDynamixCfg);
-            expect(loggerLogSpy).toHaveBeenCalledWith(
-                'CustomizationService initialized with paths from store.'
-            );
-        });
-
         it('should log error if dynamix user config path is missing', async () => {
-            // This test case is difficult to implement correctly without complex mock setup manipulation
-            // before module creation. We rely on the default mock setup providing valid paths.
-            // If the path were missing, the service would log an error and potentially fail later.
-            // We assume the mechanism works but cannot easily isolate this specific error log trigger
-            // in this setup without modifying the core mocking strategy.
-            // Skipping direct assertion for now.
-
-            // --- NEW IMPLEMENTATION ---
-            // Mock getters to return paths without dynamix-config[1]
-            const { getters: originalGetters } = await import('@app/store/index.js');
-            const originalPaths = originalGetters.paths(); // Get the full mock paths object
-            const pathsWithoutDynamixUser = {
-                ...originalPaths,
-                'dynamix-config': [originalPaths['dynamix-config'][0]],
-            }; // Modify it
-            vi.mocked(originalGetters.paths).mockReturnValueOnce(pathsWithoutDynamixUser); // Mock the return value
-
-            // Re-create service instance to pick up mocked paths during constructor/init phase if applicable
+            // Temporarily modify mockPaths to simulate missing user config path
+            const originalPaths = { ...mockPaths };
+            mockPaths['dynamix-config'] = [mockPaths['dynamix-config'][0]]; // Only keep default config
+
             await service.onModuleInit();
 
             expect(loggerErrorSpy).toHaveBeenCalledWith(
                 "Could not resolve user dynamix config path (paths['dynamix-config'][1]) from store."
             );
             // Expect subsequent operations that rely on configFile to potentially fail or not run
             expect(fs.writeFile).not.toHaveBeenCalledWith(doneFlag, 'true'); // Setup should bail early
+
+            // Restore original paths
+            mockPaths['dynamix-config'] = originalPaths['dynamix-config'];
         });
 
         it('should log error and rethrow non-ENOENT errors during activation dir access', async () => {
