build(Android): Re-enabled AAPT2 as xamarin has fixed LogicalName val…#3514
Merged
jeromelaban merged 1 commit intomasterfrom Jul 9, 2020
Merged
build(Android): Re-enabled AAPT2 as xamarin has fixed LogicalName val…#3514jeromelaban merged 1 commit intomasterfrom
jeromelaban merged 1 commit intomasterfrom
Conversation
|
|
Contributor
|
The build 17087 found UI Test snapshots differences.
|
Contributor
|
The build 17087 found UI Test snapshots differences.
|
Contributor
|
The build 17087 found UI Test snapshots differences.
|
Contributor
|
The build 17087 found UI Test snapshots differences.
|
jeromelaban
approved these changes
Jul 9, 2020
| <AndroidResgenFile>Resources\Resource.Designer.cs</AndroidResgenFile> | ||
| <!-- AndroidUseAapt2 is disabled until https://github.com/unoplatform/uno/issues/1382 is resolved --> | ||
| <AndroidUseAapt2>false</AndroidUseAapt2> | ||
| <!-- AndroidUseAapt2 re-enabled since https://github.com/xamarin/xamarin-android/pull/3327 got resolved --> |
Member
There was a problem hiding this comment.
No need to keep this comment now.
| <AndroidResgenFile>Resources\Resource.Designer.cs</AndroidResgenFile> | ||
| <!-- AndroidUseAapt2 is disabled until https://github.com/unoplatform/uno/issues/1382 is resolved --> | ||
| <AndroidUseAapt2>false</AndroidUseAapt2> | ||
| <!-- AndroidUseAapt2 re-enabled since https://github.com/xamarin/xamarin-android/pull/3327 got resolved --> |
…idation for resource files
LHuss
force-pushed
the
dev/lhu/build_reenableaapt2
branch
from
f4bdf94 to
d50a31b
Compare
Contributor
|
The build 17128 found UI Test snapshots differences.
|
Contributor
|
The build 17128 found UI Test snapshots differences.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…idation for resource files
GitHub Issue (If applicable): closes #1382
PR Type
What kind of change does this PR introduce?
What is the current behavior?
AAPT2 is disabled as it used to cause build issues when file names are invalid.
What is the new behavior?
Re-enabled AAPT2 for android. Building will now check resource files' LogicalName.
Note: This means a file with "content" build action with an invalid name will still fail the build.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):