fix(preset-mini): correct tsdown external configuration
#5031
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the external configuration in tsdown build configs for preset-mini and preset-wind3 to accurately reflect their actual dependencies. The changes ensure that build externals match the dependencies declared in each package's package.json.
- Added missing
externalconfiguration to preset-mini's tsdown config - Updated preset-wind3's external configuration to match its actual dependencies
- Removed incorrectly listed external dependencies from preset-wind3
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages-presets/preset-mini/tsdown.config.ts | Added external array with the three dependencies (@unocss/core, @unocss/rule-utils, @unocss/extractor-arbitrary-variants) |
| packages-presets/preset-wind3/tsdown.config.ts | Updated external array to match actual dependencies by removing unconfig, magic-string, and @unocss/config, and adding @unocss/preset-mini and @unocss/rule-utils |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
commit: |
This was referenced Dec 30, 2025
1 task
This was referenced Dec 30, 2025
This was referenced Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5025