Skip to content

Comments

fix(core): fix CountableSet on standard class field semantics#4437

Merged
zyyv merged 3 commits intounocss:mainfrom
hi-ogawa:refactor-CountableSet-class-field
Mar 14, 2025
Merged

fix(core): fix CountableSet on standard class field semantics#4437
zyyv merged 3 commits intounocss:mainfrom
hi-ogawa:refactor-CountableSet-class-field

Conversation

@hi-ogawa
Copy link
Contributor

@netlify
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for unocss ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a1cbf5e
🔍 Latest deploy log https://app.netlify.com/sites/unocss/deploys/67d39d65f121c400082f2a63
😎 Deploy Preview https://deploy-preview-4437--unocss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review February 18, 2025 08:36
@hi-ogawa hi-ogawa requested review from antfu and zyyv as code owners February 18, 2025 08:36
@antfu
Copy link
Member

antfu commented Feb 18, 2025

I kinda had an impression about there should be a reason why we are doing that, but need to dig a bit.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 14, 2025

Open in Stackblitz

commit: a1cbf5e

Copy link
Member

@zyyv zyyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hi-ogawa fixed, the origin counter is not counted at initialization. /cc @antfu

CountableSet is mostly used for counting utilities on the inspector.

@zyyv zyyv enabled auto-merge March 14, 2025 03:10
@zyyv zyyv added this pull request to the merge queue Mar 14, 2025
Merged via the queue into unocss:main with commit 6deb99f Mar 14, 2025
11 checks passed
@hi-ogawa hi-ogawa deleted the refactor-CountableSet-class-field branch March 14, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CountableSet with constructor arguments doesn't work

3 participants