Conversation
Member
Author
|
I've tested against the ./example/1.zero-config and the output of declare function sum(a: number, b: number): number;
export { sum as default };to: declare function sum(a: number, b: number): number;
export = sum;This is the expected types in pair with the 'use strict';
function sum(a, b) {
return a + b;
}
module.exports = sum; |
.d.cts default export type.d.cts default export type
danielroe
approved these changes
Dec 28, 2024
Member
danielroe
left a comment
There was a problem hiding this comment.
this looks good to me!
an optimisation might be to use findExports from mlly rather than maintaining a separate regexp
Contributor
|
Looks like we also need to include also this change for |
Member
|
that would depend on whether it was type: module, i assume? |
Contributor
Contributor
|
Even with type set to commonjs, unbuild generating wrong dts files, check #474, reproduction there |
This was referenced Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

resolves #457