fix: mark FormData & URLSearchParams as non-serializable for bun compatibility#483
Merged
fix: mark FormData & URLSearchParams as non-serializable for bun compatibility#483
FormData & URLSearchParams as non-serializable for bun compatibility#483Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
===========================================
+ Coverage 56.86% 70.00% +13.13%
===========================================
Files 16 17 +1
Lines 728 530 -198
Branches 113 140 +27
===========================================
- Hits 414 371 -43
+ Misses 303 148 -155
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kricsleo
changed the title
FormData as non-serializable in BunFormData & URLSearchParams as non-serializable for Bun compatibility
|
When will this be merged? |
pi0
changed the title
FormData & URLSearchParams as non-serializable for Bun compatibilityFormData & URLSearchParams as non-serializable for bun compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #439
resolves #466
Bun added
toJSONmethod toURLSearchParamsandFormData, this confused theisJSONSerializable.It’s neither Node.js behavior (Bun aims for 100% compatibility) nor standard behavior (according to MDN)