feat: have both local and global interceptors#357
Closed
Conversation
8 tasks
8 tasks
Member
|
Thank you for PR dear @enkot while some changes are nice, i found it little over complex and some against the design patterns of ofetch. For the initial step, I went with #353 which allows an array of interceptor options. A quick explanation of other parts:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes
onResponseError#160❓ Type of change
📚 Description
Currently interceptors specified in $fetch() override the interceptors in $fetch.create.
This PR implements:
handlerandstrategyfields when creating new client using$fetch.create. Available strategies:In all cases interceptor has second parameter which can be:
Names are subject to change 👀
onResponse,onResponseErrorinterceptors.If the function doesn't return anything or returns
undefined- the response data will not be overwritten.Example:
The open question is how to type the "data" parameter, currently it has type
any.We can also introduce the
defaultStrategyoption.📝 Checklist