Conversation
Member
Author
|
/cc @danielroe This does not include |
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 5 5
Lines 450 450
Branches 102 102
=======================================
Hits 414 414
Misses 36 36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #302
❓ Type of change
📚 Description
This PR exposes
SharedOptionstype, a sub type ofFetchOptionsthat is completely safe to be shared in reusable instances via global configuration. (currently timeout, retry and retryDelay) other things in the future such as respectProxy might be included.The border between choosing if something is safe to be global option or not is that it should not affect any runtime logic behavior changes.
📝 Checklist