Conversation
…om utils to make them available for external usage
|
I'm really looking forward to this PR being accepted. I've encountered the same issue myself. Directly copying the type definitions does seem a bit strange. |
Codecov Report
@@ Coverage Diff @@
## main #280 +/- ##
==========================================
- Coverage 93.46% 92.00% -1.47%
==========================================
Files 5 5
Lines 551 450 -101
Branches 102 102
==========================================
- Hits 515 414 -101
Misses 36 36
|
pi0
changed the title
ResponseType, ResponseMap, and MappedType
pi0
approved these changes
Oct 26, 2023
Member
pi0
left a comment
pi0
left a comment
There was a problem hiding this comment.
Thanks for the PR! I have rewrote on top of your work to export more type exports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
I'm building a library around ofetch that needs defines custom fetch functions with the same signature as ofetch, so ideally I would have access to these types to define the function. My current workaround is to copy-paste the types into the library but this doesn't feel quite right.
If there's a reason for these types to not be exported, just close this PR and I will stick to the workaround 👍🏼
📝 Checklist