Skip to content

Conversation

@ineshbose
Copy link
Contributor

@ineshbose ineshbose commented May 21, 2023

Similar to highlighting backticks, this adds functionality to underline.

Renamed highlightBackticks to characterFormat to chain the formatting. 🙂

Preview (based on examples/special.ts):
image

Update: added special format syntax as well (really need this feature!)

image

@ineshbose ineshbose changed the title feat(fancy): underlining words feat(fancy): underlining and special format syntax May 22, 2023
@pi0
Copy link
Member

pi0 commented May 26, 2023

I love this!!

Only regarding special formatting seems a nice idea too but can you please remove it from this PR? I like to think more together about possible edge cases and best syntax not conflicting with actual user texts.

@ineshbose
Copy link
Contributor Author

Sure, that's done. Hopefully the special formatting gets brainstormed and added soon - happy to contribute 🙂

@ineshbose ineshbose changed the title feat(fancy): underlining and special format syntax feat(fancy): underlining May 26, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 6ed7bc8 into unjs:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants