This repository was archived by the owner on Sep 6, 2024. It is now read-only.
initial commit for handling auth token#67
Merged
jamieknight-db merged 1 commit intounitycatalog:feat/login-uifrom Aug 15, 2024
Merged
initial commit for handling auth token#67jamieknight-db merged 1 commit intounitycatalog:feat/login-uifrom
jamieknight-db merged 1 commit intounitycatalog:feat/login-uifrom
Conversation
jamieknight-db
approved these changes
Aug 15, 2024
Collaborator
jamieknight-db
left a comment
jamieknight-db
left a comment
There was a problem hiding this comment.
This looks great @xx-db - will make login much more straight forward 🚀
jamieknight-db
added a commit
that referenced
this pull request
Aug 29, 2024
* start of login page * env and google auth button * merge with main, remove params reference * start of okta auth * initial commit for handling auth token (#67) * start of login with keycloak * handle google sign in with token * more google auth * profile dropdown * merge with main * merge with main * convert to axios * start of readme instructions * get current user endpoint (#70) clean up some other endpoints * commenting out UI until repositories are merged * clean up current user (#74) * yarn lock file * remove keycloak for now, node version error in jwt-decode dependency * commit yarn lock * remove state as useEffect dependency, comment out currentUser call for now --------- Co-authored-by: Xiang Xu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use axios interceptor to add access token to future requests once logged in.
No persistent of the token in cookie/storage yet, taking one step at a time.
We can come up with a design on how we want to handle refresh/storing the token in the future.