This repository was archived by the owner on Sep 6, 2024. It is now read-only.
Add ability to edit catalog description#63
Merged
jamieknight-db merged 3 commits intounitycatalog:mainfrom Aug 12, 2024
Merged
Conversation
edit modal is made to support more fields in the future if we want to edit more than just description
Collaborator
jamieknight-db
left a comment
jamieknight-db
left a comment
There was a problem hiding this comment.
Looks good! Can you include a screen recording so we can see the magic in action? Also, the linter has some suggestions for you ;)
jamieknight-db
approved these changes
Aug 8, 2024
yc-shawn
reviewed
Aug 8, 2024
Co-authored-by: Shawn Chen <[email protected]>
Romanize
approved these changes
Aug 12, 2024
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 6, 2024
…og-ui#63) * Add ability to edit catalog description edit modal is made to support more fields in the future if we want to edit more than just description * lint * feedback Co-authored-by: Shawn Chen <[email protected]> --------- Co-authored-by: Shawn Chen <[email protected]>
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 6, 2024
…og-ui#63) * Add ability to edit catalog description edit modal is made to support more fields in the future if we want to edit more than just description * lint * feedback Co-authored-by: Shawn Chen <[email protected]> --------- Co-authored-by: Shawn Chen <[email protected]>
dennyglee
pushed a commit
to unitycatalog/unitycatalog
that referenced
this pull request
Sep 6, 2024
…og-ui#63) * Add ability to edit catalog description edit modal is made to support more fields in the future if we want to edit more than just description * lint * feedback Co-authored-by: Shawn Chen <[email protected]> --------- Co-authored-by: Shawn Chen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit modal is made to support more fields in the future if we want to edit more than just description
Edit.Catalog.Description.mov
closes: #38