This repository was archived by the owner on Sep 6, 2024. It is now read-only.
Merged
Conversation
Collaborator
Author
|
@xx-db I'm tagging you in a comment in hopes that it lets me add you as a reviewer 🙏 |
yc-shawn
approved these changes
Aug 7, 2024
| } | ||
|
|
||
| export function useDeleteSchema({ | ||
| onSuccessCallback, |
Collaborator
There was a problem hiding this comment.
Sorry I just captured this.
You don't need to do create a new prop here to handle on success.
You can just simply do onSuccess in the caller
mutation.mutate(values, {
onSuccess: () => {}
});Can we have follow-up PRs to remove this pattern on other deletion hooks?
Collaborator
Author
There was a problem hiding this comment.
Do you mean to move the invalidateQueries to the caller as well?
Collaborator
There was a problem hiding this comment.
Nope, keep invalidateQueries in the mutation hook.
It would works for both cases
Collaborator
Collaborator
Author
There was a problem hiding this comment.
Ok got it, but we don't need to pass in onSuccessCallback. I will do a follow-on PR to remove all those. Thanks @yc-shawn 👍
Romanize
approved these changes
Aug 7, 2024
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 6, 2024
* delete schema functionality * prettier
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 6, 2024
* delete schema functionality * prettier
dennyglee
pushed a commit
to unitycatalog/unitycatalog
that referenced
this pull request
Sep 6, 2024
* delete schema functionality * prettier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-08-07.at.2.59.45.PM.mov
Closes #36