Update auth-related openapi specification.#771
Merged
jamieknight-db merged 53 commits intounitycatalog:mainfrom Mar 10, 2025
Merged
Update auth-related openapi specification.#771jamieknight-db merged 53 commits intounitycatalog:mainfrom
jamieknight-db merged 53 commits intounitycatalog:mainfrom
Conversation
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
ognis1205
changed the title
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
ognis1205
requested review from
dennyglee,
rameshchandra and
tdas
as code owners
Contributor
Author
|
cc: @creechy |
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
creechy
reviewed
Dec 11, 2024
creechy
reviewed
Dec 11, 2024
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
creechy
reviewed
Jan 21, 2025
examples/cli/src/main/java/io/unitycatalog/cli/utils/Oauth2CliExchange.java
Outdated
Show resolved
Hide resolved
creechy
reviewed
Jan 21, 2025
examples/cli/src/main/java/io/unitycatalog/cli/utils/Oauth2CliExchange.java
Outdated
Show resolved
Hide resolved
creechy
reviewed
Jan 21, 2025
examples/cli/src/main/java/io/unitycatalog/cli/utils/Oauth2CliExchange.java
Outdated
Show resolved
Hide resolved
creechy
suggested changes
Jan 21, 2025
Collaborator
creechy
left a comment
creechy
left a comment
There was a problem hiding this comment.
A bunch of nits and small questions, otherwise looking good.
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
…anges. Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Contributor
Author
|
I have addressed all of @creechy 's feedback. As a result, I made some changes to |
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Contributor
Author
|
Just checking in—any updates on this? |
jamieknight-db
approved these changes
Feb 8, 2025
Collaborator
jamieknight-db
left a comment
jamieknight-db
left a comment
There was a problem hiding this comment.
Looks good from a UI perspective. Thanks @ognis1205!
Collaborator
This looks good from the UI side, it looks like @creechy will need to re-review before we can merge. |
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
Contributor
Author
|
Just checking in—any updates on this? |
Signed-off-by: Shingo OKAWA <[email protected]>
Signed-off-by: Shingo OKAWA <[email protected]>
creechy
approved these changes
Feb 28, 2025
Collaborator
creechy
left a comment
creechy
left a comment
There was a problem hiding this comment.
lgtm. I did a quick Google auth test with the CLI worked fine for me.
Contributor
Author
|
Thank you for patiently reviewing it! |
Signed-off-by: Shingo OKAWA <[email protected]>
Contributor
Author
|
I think this is ready to be merged. Can we merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updatedDescription of changes
Fixed the server bootstrap order to ensure proper initialization.Will close #768 .