Closed
Conversation
Update public to private
Contributor
Author
|
please help to review |
Contributor
Author
|
@tdas tdas |
Contributor
|
Could you clarify the reason behind switching this from TL;DR this change may hamper any code trying to access these variables. |
tdas
reviewed
Jun 20, 2024
| @@ -7,9 +7,9 @@ | |||
| */ | |||
| @javax.annotation.Generated(value = "org.openapitools.codegen.languages.JavaClientCodegen", comments = "Generator version: 7.5.0") | |||
| public class ServerVariable { | |||
Contributor
There was a problem hiding this comment.
this is generated code. so we do not manually modify this code.
tdas
reviewed
Jun 20, 2024
Contributor
tdas
left a comment
tdas
left a comment
There was a problem hiding this comment.
We will not accept any changes to generated code. Please close your PR.
Contributor
|
Closing this PR. If you have other changes you want to propose in non-generated code, please make another PR. |
dennyglee
pushed a commit
that referenced
this pull request
Sep 2, 2024
tdas
pushed a commit
that referenced
this pull request
Sep 5, 2024
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update public to private
PR Checklist
docsis updatedDescription of changes