Skip to content

Merge unitycatalog-ui into this repo under the ui directory#412

Closed
tdas wants to merge 46 commits intomainfrom
merge-ui-to-main-2
Closed

Merge unitycatalog-ui into this repo under the ui directory#412
tdas wants to merge 46 commits intomainfrom
merge-ui-to-main-2

Conversation

@tdas
Copy link
Contributor

@tdas tdas commented Sep 5, 2024

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

This PR moves all the code and commit history in the current github.com/unitycatalog/unitycatalog-ui repo to this repo, under the UI directory. This has a bunch of redundant files like .gitignore, CONTRIBUTING, etc. which can be removed later once these commits have been non-squash merged while preserving history.

yc-shawn and others added 30 commits September 5, 2024 02:28
* feat: ✨ Add CatalogsList page + ListWrapper

* extract format timestamp to util + add interaction to list rows
* feat: ✨ Add CatalogsList page + ListWrapper

* extract format timestamp to util + add interaction to list rows

* feat: ✨ Add details layout + catalog-details hook
* feat: ✨ Add CatalogsList page + ListWrapper

* extract format timestamp to util + add interaction to list rows

* add sidebar layout + catalog sidebar
* feat: ✨ Add SchemaDetails Page + getSchema hook
* feat: ✨ Add schema tabs for functions tables and volumes
* feat: ✨ Add FunctionDetails page + sidebar with details

* add breadcrumbs

* add icon

* add code block for function def

* lint
* feat: ✨ Add TableDetails page + Table Sidebar details + fix metadata labels

* add volume icon to details header
* feat: ✨ Create catalog flow

* prefer invalidate queries for refetching all catalogs
* Update README.md

* Update README.md
* delete table feature

* handle onSuccess callback, navigate, display notification

* PR feedback

* More pr feedback

* change button type

* tableFullName prop

* memoize
JuanPabloDiaz and others added 16 commits September 5, 2024 02:28
* Add CONTRIBUTING.md with contribution guidelines

closes #26

* Fix indentation
* Add code style check

add style check workflow

* move prettier to devDependencies
* Add Code of Conduct link to CONTRIBUTING.md

* removed unnecessary indentation

* Update CONTRIBUTING.md with governance and communication guidelines

Add a new CODE_OF_CONDUCT.md
* delete schema functionality

* prettier
* Add ability to edit catalog description

edit modal is made to support more fields in the future if we want to edit more than just description

* lint

* feedback

Co-authored-by: Shawn Chen <[email protected]>

---------

Co-authored-by: Shawn Chen <[email protected]>
* start of login page

* env and google auth button

* merge with main, remove params reference

* start of okta auth

* initial commit for handling auth token (#67)

* start of login with keycloak

* handle google sign in with token

* more google auth

* profile dropdown

* merge with main

* merge with main

* convert to axios

* start of readme instructions

* get current user endpoint (#70)

clean up some other endpoints

* commenting out UI until repositories are merged

* clean up current user (#74)

* yarn lock file

* remove keycloak for now, node version error in jwt-decode dependency

* commit yarn lock

* remove state as useEffect dependency, comment out currentUser call for now

---------

Co-authored-by: Xiang Xu <[email protected]>
Updating readme.md to reflect archival process.
@tdas tdas changed the title Merge unitycatalog-ui to this repo under the ui directory Merge unitycatalog-ui into this repo under the ui directory Sep 5, 2024
Copy link
Contributor

@dennyglee dennyglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking...

@robertgv
Copy link
Contributor

robertgv commented Sep 5, 2024

@tdas @dennyglee The LICENSE, CONTRIBUTIG and CODE_OF_CONDUCT documents are already on the base of this repo. I think they can be excluded on this PR.

@dennyglee
Copy link
Contributor

Closing as this was resolved with #421

@dennyglee dennyglee closed this Sep 6, 2024
@tdas tdas deleted the merge-ui-to-main-2 branch September 26, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants